use crc32_z and adler32_z if available at compile time #92369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Every change to Python requires a NEWS entry. Please, add it using the blurb_it Web app or the blurb command-line tool. |
Contributor
Author
|
not sure about the small buffers thing... maybe i should leave that part in |
landfillbaby
force-pushed
the
main
branch
4 times, most recently
from
3041f38 to
b475212
Compare
Contributor
Author
|
should there be macro like |
landfillbaby
changed the title
Contributor
|
Personally, I find the existing code to be simpler and don't see any advantage to adding an unnecessary |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
they've been in zlib since v1.2.9, so why not use them? also use PyLong_FromUnsignedLong directly to avoid useless clinic error checks
feel free to squash this with an edited commit message