X Tutup
The Wayback Machine - https://web.archive.org/web/20260105123734/https://github.com/python/cpython/pull/19214
Skip to content

bpo-40101: Fix parser's assumption about the return value of convert #19214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
isidentical wants to merge 2 commits into from
Closed

bpo-40101: Fix parser's assumption about the return value of convert #19214

isidentical wants to merge 2 commits into from

Conversation

@isidentical
Copy link
Member

@isidentical isidentical commented Mar 29, 2020 •
edited
Loading

@isidentical isidentical added the type-bug An unexpected behavior, bug, or error label Mar 29, 2020
@isidentical isidentical changed the title bpo-40001: Fix parser's assumption about the return value of convert bpo-40101: Fix parser's assumption about the return value of convert Mar 29, 2020
@isidentical isidentical requested a review from benjaminp April 6, 2020 22:19
@benjaminp
Copy link
Contributor

benjaminp commented Apr 9, 2020

Why not move the responsibility for setting used_names on the root node into driver.py?

@isidentical
Copy link
Member Author

isidentical commented Apr 11, 2020

Why not move the responsibility for setting used_names on the root node into driver.py?

Because that would change the current behavior for no reason. But if it is needed, I can move it.

pablogsal
pablogsal reviewed May 16, 2020
View reviewed changes
@isidentical isidentical requested a review from pablogsal May 19, 2020 19:32
@python python deleted a comment from MaxwellDupre Mar 14, 2022
@MaxwellDupre
Copy link
Contributor

MaxwellDupre commented Apr 22, 2022

I get on the first line:
cpython/Lib/unittest/loader.py:154: DeprecationWarning: lib2to3 package is deprecated and may not be able to parse Python 3.10+
And at end I get:
Ran 106 tests in 14.534s
FAILED (errors=12)
I guess this is irrelevant?

@ambv
Copy link
Contributor

ambv commented May 17, 2022

This missed the boat for inclusion in Python 3.9 which accepts security fixes only as of today.

@isidentical isidentical mentioned this pull request Jun 24, 2022
Closed
@StanFromIreland
Copy link
Member

StanFromIreland commented Sep 11, 2025

Triage: Issue has been closed as not planned, this PR is no longer necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjaminp benjaminp Awaiting requested review from benjaminp

@pablogsal pablogsal Awaiting requested review from pablogsal

Assignees

No one assigned

Labels

awaiting review type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@isidentical @benjaminp @MaxwellDupre @ambv @StanFromIreland @pablogsal @the-knights-who-say-ni @ezio-melotti @bedevere-bot
X Tutup