X Tutup
The Wayback Machine - https://web.archive.org/web/20220512060004/https://github.com/python/cpython/issues/85654
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docstring errors in ipaddress.IPv4Network #85654

Open
ericfrederich mannequin opened this issue Aug 4, 2020 · 8 comments
Open

docstring errors in ipaddress.IPv4Network #85654

ericfrederich mannequin opened this issue Aug 4, 2020 · 8 comments
Labels
3.8 3.9 3.10 docs type-bug

Comments

@ericfrederich
Copy link
Mannequin

@ericfrederich ericfrederich mannequin commented Aug 4, 2020

BPO 41482
Nosy @terryjreedy, @ericvsmith, @ericfrederich, @miss-islington
PRs
  • #21736
  • #21746
  • #21747
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = None
created_at = <Date 2020-08-04.19:54:05.292>
labels = ['type-bug', '3.8', '3.9', '3.10', 'docs']
title = 'docstring errors in ipaddress.IPv4Network'
updated_at = <Date 2020-08-05.22:03:53.292>
user = 'https://github.com/ericfrederich'

    bugs.python.org fields:

    activity = <Date 2020-08-05.22:03:53.292>
actor = 'eric.smith'
assignee = 'docs@python'
closed = False
closed_date = None
closer = None
components = ['Documentation']
creation = <Date 2020-08-04.19:54:05.292>
creator = 'eric.frederich'
dependencies = []
files = []
hgrepos = []
issue_num = 41482
keywords = ['patch']
message_count = 8.0
messages = ['374841', '374894', '374902', '374903', '374904', '374905', '374906', '374907']
nosy_count = 6.0
nosy_names = ['terry.reedy', 'eric.smith', 'docs@python', 'python-dev', 'eric.frederich', 'miss-islington']
pr_nums = ['21736', '21746', '21747']
priority = 'normal'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue41482'
versions = ['Python 3.8', 'Python 3.9', 'Python 3.10']
    @ericfrederich
    Copy link
    Mannequin Author

    @ericfrederich ericfrederich mannequin commented Aug 4, 2020

    The __init__ method for IPv4Network has a typo where it says all three of '192.0.2.0/24', '192.0.2.0/255.255.255.0' and '192.0.0.2/0.0.0.255' should be equal.

    @ericfrederich ericfrederich mannequin added type-feature 3.7 3.10 3.8 3.9 labels Aug 4, 2020
    @ericfrederich ericfrederich mannequin assigned docspython Aug 4, 2020
    @ericfrederich ericfrederich mannequin added type-feature docs 3.7 3.10 3.8 3.9 labels Aug 4, 2020
    @ericfrederich ericfrederich mannequin assigned docspython Aug 4, 2020
    @ericfrederich ericfrederich mannequin added the docs label Aug 4, 2020
    @ericvsmith
    Copy link
    Member

    @ericvsmith ericvsmith commented Aug 5, 2020

    New changeset 52f9842 by Eric L. Frederich in branch 'master':
    bpo-41482: Fix error in ipaddress.IPv4Network docstring (GH-21736)
    52f9842

    @terryjreedy
    Copy link
    Member

    @terryjreedy terryjreedy commented Aug 5, 2020

    The issue resulting in the addition of a "backport-52f9842-3.9" branch to the main python/cpython repository. I believe that this is a mistake and should be removed, but I don't know how.

    When miss-islington fails to backport for reasons other than a merge conflict, the problem is likely transient -- perhaps a timing issue or temporary resource unavailable issue that we have no control over. The solution is to delete the backport label, close the label box, reopen the label box, add the label, and reclose. I did this and the auto backport was generated. (The 3.8 backport is ready to approve and merge.)

    @terryjreedy terryjreedy added type-bug and removed 3.7 type-feature labels Aug 5, 2020
    @miss-islington
    Copy link
    Contributor

    @miss-islington miss-islington commented Aug 5, 2020

    New changeset b5789a7 by Miss Islington (bot) in branch '3.8':
    bpo-41482: Fix error in ipaddress.IPv4Network docstring (GH-21736)
    b5789a7

    @terryjreedy
    Copy link
    Member

    @terryjreedy terryjreedy commented Aug 5, 2020

    Since this is a trivial typo fix, I approved the backport for auto-merge.

    @terryjreedy
    Copy link
    Member

    @terryjreedy terryjreedy commented Aug 5, 2020

    I was able to delete the spurious branch because it was not protected.

    @miss-islington
    Copy link
    Contributor

    @miss-islington miss-islington commented Aug 5, 2020

    New changeset b49b88a by Miss Islington (bot) in branch '3.9':
    bpo-41482: Fix error in ipaddress.IPv4Network docstring (GH-21736)
    b49b88a

    @ericvsmith
    Copy link
    Member

    @ericvsmith ericvsmith commented Aug 5, 2020

    Thanks, Terry. That was my fault, trying to cherry pick manually. I'm not sure why the original backport failed, and once I did the manual cherry pick as suggested I got called away for real work. As you say, I should have tried deleting the tag and re-adding it before I pulled out the cherry pick tool.

    Thank you for cleaning up after me.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.8 3.9 3.10 docs type-bug
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @ericvsmith @terryjreedy @miss-islington
    X Tutup