X Tutup
The Wayback Machine - https://web.archive.org/web/20220512051224/https://github.com/python/cpython/issues/85647
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make __future__.annotations default 3.10 in What's New 3.7 #85647

Open
cool-RR mannequin opened this issue Aug 4, 2020 · 11 comments
Open

Make __future__.annotations default 3.10 in What's New 3.7 #85647

cool-RR mannequin opened this issue Aug 4, 2020 · 11 comments
Labels
3.8 3.9 3.10 docs

Comments

@cool-RR
Copy link
Mannequin

@cool-RR cool-RR mannequin commented Aug 4, 2020

BPO 41475
Nosy @rhettinger, @ned-deily, @cool-RR, @ambv, @YoSTEALTH, @miss-islington
PRs
  • #21733
  • #21832
  • #21833
  • #21835
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = None
created_at = <Date 2020-08-04.14:36:38.674>
labels = ['3.8', '3.9', '3.10', 'docs']
title = "Make __future__.annotations default 3.10 in What's New 3.7"
updated_at = <Date 2020-08-12.10:38:41.902>
user = 'https://github.com/cool-RR'

    bugs.python.org fields:

    activity = <Date 2020-08-12.10:38:41.902>
actor = 'ned.deily'
assignee = 'docs@python'
closed = False
closed_date = None
closer = None
components = ['Documentation']
creation = <Date 2020-08-04.14:36:38.674>
creator = 'cool-RR'
dependencies = []
files = []
hgrepos = []
issue_num = 41475
keywords = ['patch']
message_count = 11.0
messages = ['374814', '374833', '374839', '374849', '374885', '374886', '374887', '375185', '375187', '375220', '375221']
nosy_count = 7.0
nosy_names = ['rhettinger', 'ned.deily', 'cool-RR', 'docs@python', 'lukasz.langa', 'YoSTEALTH', 'miss-islington']
pr_nums = ['21733', '21832', '21833', '21835']
priority = 'normal'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = None
url = 'https://bugs.python.org/issue41475'
versions = ['Python 3.8', 'Python 3.9', 'Python 3.10']
    @cool-RR
    Copy link
    Mannequin Author

    @cool-RR cool-RR mannequin commented Aug 4, 2020

    Writing the patch now.

    @cool-RR cool-RR mannequin added the 3.7 label Aug 4, 2020
    @cool-RR cool-RR mannequin assigned docspython Aug 4, 2020
    @cool-RR cool-RR mannequin added docs 3.7 labels Aug 4, 2020
    @cool-RR cool-RR mannequin assigned docspython Aug 4, 2020
    @cool-RR cool-RR mannequin added docs 3.8 3.9 3.10 type-crash labels Aug 4, 2020
    @rhettinger
    Copy link
    Contributor

    @rhettinger rhettinger commented Aug 4, 2020 

    $ python3.9
Python 3.9.0b4 (v3.9.0b4:69dec9c8d2, Jul  2 2020, 18:41:53)
[Clang 6.0 (clang-600.0.57)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> from __future__ import annotations
>>> annotations
_Feature((3, 7, 0, 'beta', 1), (4, 0, 0, 'alpha', 0), 16777216)

    @rhettinger rhettinger changed the title Fix mistake in "What's new in Python 3.7" __future__.annotations set to become default in Python 4.0? Aug 4, 2020
    @rhettinger rhettinger removed the type-crash label Aug 4, 2020
    @rhettinger rhettinger changed the title Fix mistake in "What's new in Python 3.7" __future__.annotations set to become default in Python 4.0? Aug 4, 2020
    @rhettinger rhettinger removed the type-crash label Aug 4, 2020
    @cool-RR
    Copy link
    Mannequin Author

    @cool-RR cool-RR mannequin commented Aug 4, 2020

    If you'd like me to patch that too, let me know. Also, I'll need a decision on whether it should be on a separate PR and if so, to which versions it should be backported.

    @rhettinger
    Copy link
    Contributor

    @rhettinger rhettinger commented Aug 4, 2020

    Keep it focused one place — there's no benefit to multiple tracker entries and/or multiple PRs. Do look to see all the places that would be need to be updated. Also, let Łukasz reply — this was his PEP.

    Also, I'm not sure that we're backporting anything to 3.7 at this point.

    @YoSTEALTH
    Copy link
    Mannequin

    @YoSTEALTH YoSTEALTH mannequin commented Aug 5, 2020

    @rhettinger https://bugs.python.org/issue41314

    @cool-RR
    Copy link
    Mannequin Author

    @cool-RR cool-RR mannequin commented Aug 5, 2020

    Thanks for linking that, YoStealth. Unless I'm missing anything, it looks like there's agreement that the right answer is 3.10, and my PR fixes a spot which was omitted in the PR from the previous issues. Agreed?

    @YoSTEALTH
    Copy link
    Mannequin

    @YoSTEALTH YoSTEALTH mannequin commented Aug 5, 2020

    @cool-RR since your patch focuses on 3.7 there might be a merge issue.

    There might be other place where 4.0 is mentioned though. Its better to let core dev like Raymond make the call.

    @terryjreedy terryjreedy removed the 3.7 label Aug 11, 2020
    @terryjreedy terryjreedy changed the title __future__.annotations set to become default in Python 4.0? Make __future__.annotations default 3.10 in What's New 3.7 Aug 11, 2020
    @terryjreedy terryjreedy removed the 3.7 label Aug 11, 2020
    @terryjreedy terryjreedy changed the title __future__.annotations set to become default in Python 4.0? Make __future__.annotations default 3.10 in What's New 3.7 Aug 11, 2020
    @ambv
    Copy link
    Contributor

    @ambv ambv commented Aug 11, 2020

    New changeset 76643c1 by Ram Rachum in branch 'master':
    bpo-41475: Fix note in "What's new in 3.7" (bpo-21733)
    76643c1

    @ambv
    Copy link
    Contributor

    @ambv ambv commented Aug 11, 2020

    New changeset 5de00f6 by Miss Islington (bot) in branch '3.9':
    bpo-41475: Fix note in "What's new in 3.7" (GH-21733) (bpo-21832)
    5de00f6

    @ned-deily
    Copy link
    Member

    @ned-deily ned-deily commented Aug 12, 2020

    New changeset a8ad127 by Miss Islington (bot) in branch '3.7':
    bpo-41475: Fix note in "What's new in 3.7" (GH-21733) (GH-21835)
    a8ad127

    @ned-deily
    Copy link
    Member

    @ned-deily ned-deily commented Aug 12, 2020

    New changeset 622d90f by Miss Islington (bot) in branch '3.8':
    bpo-41475: Fix note in "What's new in 3.7" (GH-21733) (GH-21833)
    622d90f

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.8 3.9 3.10 docs
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    4 participants
    @ambv @rhettinger @ned-deily @terryjreedy
    X Tutup