X Tutup
The Wayback Machine - https://web.archive.org/web/20220519144932/https://github.com/python/cpython/pull/92544
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-92417: socket docs: remove references to Python <3.3 #92544

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

AlexWaygood
Copy link
Member

@AlexWaygood AlexWaygood commented May 9, 2022

@rhettinger
Copy link
Contributor

@rhettinger rhettinger commented May 9, 2022

Please don't backport any of these. Only actual bug fixes should be back ported.

@JelleZijlstra
Copy link
Member

@JelleZijlstra JelleZijlstra commented May 9, 2022

The devguide (https://devguide.python.org/gh-labels/?highlight=backport) says "Generally, backports to the maintenance branches are primarily bugfixes and documentation clarifications." This is a documentation clarification, so it seems fine to backport it.

Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

I am not sure about this. We still keep versionchanged directives for versions >= 3.0 in docs. Even if nobody currently uses Python 3.2, the old (and still working) code can have references to IOError.

@AlexWaygood
Copy link
Member Author

@AlexWaygood AlexWaygood commented May 10, 2022

I am not sure about this. We still keep versionchanged directives for versions >= 3.0 in docs. Even if nobody currently uses Python 3.2, the old (and still working) code can have references to IOError.

That's a good point. IOError isn't mentioned anywhere else in the chunk docs, so I'll revert those changes. (chunk is also now deprecated, so probably not worth worrying about.)

socket.error is documented elsewhere in the module, though, so I think it makes sense to remove the note in the socket docs. Do you agree?

@AlexWaygood AlexWaygood changed the title gh-92417: chunk docs, socket docs: remove references to Python <3.3 gh-92417: socket docs: remove references to Python <3.3 May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants
X Tutup