Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Add test component for multiple formats support #1070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vpereira
force-pushed
the
multiple_formats_support
branch
from
2cad89f
to
3c2e90a
Compare
vpereira
force-pushed
the
multiple_formats_support
branch
from
3c2e90a
to
cede0da
Compare
joelhawksley
reviewed
Sep 13, 2021
Thanks for adding this test case! We should pair on making it pass
Email me: joelhawksley@github.com
|
|
||
| class ViewComponentMultipleFormatsTest < ViewComponent::TestCase | ||
| def test_render_html | ||
| render_inline(MyComponentMultipleFormat.new, format: :html) |
There was a problem hiding this comment.
Wouldn't the format be set by the request? I'm guessing we'd need to add a with_request_format test helper.
There was a problem hiding this comment.
Ok, I started with a skeleton code/pseudo code.
What I'm thinking to do is:
- check if there is a view for
#{component}.#{format}.#{extension}. if it exists, set it as view.
Co-authored-by: Joel Hawksley <joelhawksley@github.com>
vpereira
force-pushed
the
multiple_formats_support
branch
from
1e58d68
to
5487678
Compare
vpereira
force-pushed
the
multiple_formats_support
branch
from
f6aa825
to
c5a1f3d
Compare
|
@joelhawksley any reason why |
|
@vpereira we are not using the ActionView context as we want to keep ViewComponent templates separate from ActionView. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
As asked by @joelhawksley on issue #1062, I'm opening a PR with a test component with multiple formats (html and text)
Feel free to guide me if something is missing.