gh-92210: Port of Cinder's socket.__init__ which uses argument clinic. #92237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zitterbewegung
changed the title
erlend-aasland
reviewed
May 3, 2022
erlend-aasland
reviewed
May 3, 2022
Misc/NEWS.d/next/Library/2022-05-03-15-55-04.gh-issue-92210.L3xp33.rst
Outdated
Show resolved
Hide resolved
|
Please use |
erlend-aasland
reviewed
May 3, 2022
| @@ -0,0 +1 @@ | |||
| Port of Cinder's ``socket.__init__`` which uses argument clinic cpython. | |||
There was a problem hiding this comment.
git rm "Misc/NEWS.d/next/Library/2022-05-03-17-29-04.gh-issue-92210.csDOQM.rst"
There was a problem hiding this comment.
(There are still two NEWS entries; the newest you added is better than this one.)
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
erlend-aasland
reviewed
May 3, 2022
Misc/NEWS.d/next/Library/2022-05-03-17-33-46.gh-issue-92210.csDOQM.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>
erlend-aasland
approved these changes
May 3, 2022
|
@ambv, can you kick the CI? |
|
I'm not ambv but I kicked it. I'll take a look now and probably merge. |
JelleZijlstra
approved these changes
May 3, 2022
facebook-github-bot
pushed a commit
to facebookincubator/cinder
that referenced
this pull request
Jul 1, 2022
Summary: Original Diff: D23323432 by vladima, reviewed by carljm This makes arg parsing somewhat faster. This was already merged upstream in python/cpython#92237 We are leaving out the argclinic use in `lru_cache.__new__` for 3.10; this was rejected upstream and should not be hot enough to matter. Reviewed By: itamaro Differential Revision: D37555740 fbshipit-source-id: 895ebb0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
gh-92210: Port of Cinder's socket.init which uses argument clinic.