X Tutup
The Wayback Machine - https://web.archive.org/web/20220504040027/https://github.com/nodejs/node-v8/pull/181/commits
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Action to lint upstream v8 #181

Closed
wants to merge 20 commits into from
Closed

Commits on Oct 19, 2020

  1. deps: V8: un-cherry-pick bd019bd

    Original commit message:
    
        [testrunner] delete ancient junit compatible format support
    
        Testrunner has ancient support for JUnit compatible XML output.
    
        This CL removes this old feature.
    
        R=mstarzinger@chromium.org,jgruber@chromium.org,jkummerow@chromium.org
        CC=​machenbach@chromium.org
    
        Bug: v8:8728
        Change-Id: I7e1beb011dbaec3aa1a27398a5c52abdd778eaf0
        Reviewed-on: https://chromium-review.googlesource.com/c/1430065
        Reviewed-by: Jakob Gruber <jgruber@chromium.org>
        Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
        Commit-Queue: Tamer Tas <tmrts@chromium.org>
        Cr-Commit-Position: refs/heads/master@{#59045}
    
    Refs: v8/v8@bd019bd
    
    PR-URL: nodejs/node#32116
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    refack authored and nodejs-ci committed Oct 19, 2020
  2. deps: patch V8 to run on older XCode versions

    Patch V8 (compiler/js-heap-broker.cc) to remove the use of an optional
    property, which is a fairly new C++ feature, since that requires a newer
    XCode version than the minimum requirement in BUILDING.md and thus
    breaks CI.
    
    PR-URL: nodejs/node#32116
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    ryzokuken authored and nodejs-ci committed Oct 19, 2020
  3. deps: V8: patch register-arm64.h

    Fixes a compilation issue on some platforms
    
    PR-URL: nodejs/node#32116
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    refack authored and nodejs-ci committed Oct 19, 2020
  4. deps: V8: forward declaration of Rtl*FunctionTable

    This should be semver-patch since actual invocation is version
    conditional.
    
    PR-URL: nodejs/node#32116
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    refack authored and nodejs-ci committed Oct 19, 2020
  5. deps: make v8.h compatible with VS2015

    There is a bug in the most recent version of VS2015 that affects v8.h
    and therefore prevents compilation of addons.
    
    Refs: https://stackoverflow.com/q/38378693
    
    PR-URL: nodejs/node#32116
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    joaocgreis authored and nodejs-ci committed Oct 19, 2020
  6. deps: V8: silence irrelevant warnings

    PR-URL: nodejs/node#26685
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    
    PR-URL: nodejs/node#32116
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    targos authored and nodejs-ci committed Oct 19, 2020
  7. deps: patch V8 to run on Xcode 8

    Patch V8 (wasm/wasm-module.cc) to remove const qualifier from type
    passed to template call of `OwnedVector::Of`. Xcode 8 can't convert
    'OwnedVector<unsigned char>' to 'OwnedVector<const unsigned char>' when
    returning from a function (which is likely a bug on Xcode, considering
    this worked on the prior version of Xcode as well as newer versions).
    This workaround shouldn't affect the application, since the const
    qualifier is preserved in the AsmJsOffsetInformation::encoded_offset_.
    
    There's also a V8 test passing a const-qualified type to ::Of, but since
    we don't test V8 on Xcode 8, it should be fine to leave it as is.
    
    Signed-off-by: Matheus Marchini <mmarchini@netflix.com>
    
    PR-URL: nodejs/node#32116
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    mmarchini authored and nodejs-ci committed Oct 19, 2020
  8. deps: update V8 postmortem metadata script

    This commit updates V8's gen-postmortem-metadata.py script
    to fix SmartOS compilation for V8 8.4.
    
    PR-URL: nodejs/node#33579
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Shelley Vohr <codebytere@gmail.com>
    cjihrig authored and nodejs-ci committed Oct 19, 2020
  9. deps: update V8 postmortem metadata script

    This commit updates V8's gen-postmortem-metadata.py script to
    fix SmartOS compilation with V8 8.5.
    
    PR-URL: nodejs/node#35415
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    cjihrig authored and nodejs-ci committed Oct 19, 2020
  10. deps: fix platform-embedded-file-writer-win for ARM64

    PR-URL: nodejs/node#35415
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    targos authored and nodejs-ci committed Oct 19, 2020
  11. deps: fix V8 build issue with inline methods

    PR-URL: nodejs/node#35415
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    gengjiawen authored and nodejs-ci committed Oct 19, 2020
  12. src: fix v8 api deprecation

    gengjiawen authored and nodejs-ci committed Oct 19, 2020
  13. tools: update V8 gypfiles for 8.7

    targos authored and nodejs-ci committed Oct 19, 2020
  14. tools: update V8 gypfiles

    until 718fbb89ef9079c142cf252488a571b620493e6f
    targos authored and nodejs-ci committed Oct 19, 2020
  15. V8: make final method

    targos authored and nodejs-ci committed Oct 19, 2020
  16. V8: fix using namespace

    targos authored and nodejs-ci committed Oct 19, 2020

Commits on Oct 20, 2020

  1. GitHub Action to lint upstream v8

    % __flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics__
    ```
    ./v8/tools/dev/update-compile-commands.py:55:25: F821 undefined name 'Error'
        if code != 0: raise Error("gn gen failed")
                            ^
    ./v8/tools/clusterfuzz/js_fuzzer/tools/minimize.py:26:1: F631 assertion is always true, perhaps remove parentheses?
    assert(len(sys.argv) > 1, 'Need to specify minimizer path.')
    ^
    1     F631 assertion is always true, perhaps remove parentheses?
    1     F821 undefined name 'Error'
    2
    ```
    cclauss committed Oct 20, 2020
X Tutup