Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd performance relayer + documentation (web-vitals) #9116
Conversation
|
Hi @housseindjirdeh! Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
I haven't tested this, but it looks good at an overview, and the docs look great. This is something we definitely talked about getting into the next release - and I'd love to see it make it. Thoughts @ianschmitz @iansu? |
b812d97
|
FWIW, I think this is good to go |
|
I've tested this on a project today and it works well. Obviously the extension works with or without this, but being able to report on this is really valuable. |
8fda779
into
facebook:master
|
Thanks a ton @housseindjirdeh! Much appreciated. |
|
Awesome thanks all! So happy to see this land :) |

Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.

Fixes #8996
Changes included:
web-vitalslibreportWebVitalsfunction to index.js template (doesn't do anything until a function is passed in)