X Tutup
The Wayback Machine - https://web.archive.org/web/20201101024349/https://github.com/facebook/create-react-app/pull/9116
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add performance relayer + documentation (web-vitals) #9116

Merged
merged 6 commits into from Jun 11, 2020

Conversation

@housseindjirdeh
Copy link
Contributor

@housseindjirdeh housseindjirdeh commented Jun 5, 2020

Fixes #8996

Changes included:

  • Dynamically imports the web-vitals lib
  • Includes a reportWebVitals function to index.js template (doesn't do anything until a function is passed in)
  • Adds a "Measuring Performance" page to the documentation
@facebook-github-bot
Copy link

@facebook-github-bot facebook-github-bot commented Jun 5, 2020

Hi @housseindjirdeh!

Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

@facebook-github-bot facebook-github-bot commented Jun 5, 2020

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Copy link
Collaborator

@mrmckeb mrmckeb left a comment

I haven't tested this, but it looks good at an overview, and the docs look great. This is something we definitely talked about getting into the next release - and I'd love to see it make it.

Thoughts @ianschmitz @iansu?

@iansu iansu mentioned this pull request Jun 7, 2020
0 of 23 tasks complete
@housseindjirdeh housseindjirdeh force-pushed the housseindjirdeh:add-performance-relayer branch to b812d97 Jun 7, 2020
@mrmckeb
mrmckeb approved these changes Jun 9, 2020
@mrmckeb mrmckeb added this to the 4.0 milestone Jun 9, 2020
@mrmckeb mrmckeb added this to In progress in v4 via automation Jun 9, 2020
Copy link
Contributor

@kentcdodds kentcdodds left a comment

FWIW, I think this is good to go 👍

@ianschmitz ianschmitz closed this Jun 10, 2020
v4 automation moved this from In progress to Done Jun 10, 2020
@ianschmitz ianschmitz reopened this Jun 10, 2020
v4 automation moved this from Done to In progress Jun 10, 2020
@mrmckeb
Copy link
Collaborator

@mrmckeb mrmckeb commented Jun 11, 2020

I've tested this on a project today and it works well. Obviously the extension works with or without this, but being able to report on this is really valuable.

@ianschmitz ianschmitz changed the title Adds performance relayer + documentation (web-vitals) Add performance relayer + documentation (web-vitals) Jun 11, 2020
@ianschmitz ianschmitz merged commit 8fda779 into facebook:master Jun 11, 2020
15 checks passed
15 checks passed
facebook.create-react-app Build #20200610.8 succeeded
Details
facebook.create-react-app (Behavior LinuxNode10) Behavior LinuxNode10 succeeded
Details
facebook.create-react-app (Behavior LinuxNode12) Behavior LinuxNode12 succeeded
Details
facebook.create-react-app (Behavior MacNode10) Behavior MacNode10 succeeded
Details
facebook.create-react-app (Behavior MacNode12) Behavior MacNode12 succeeded
Details
facebook.create-react-app (Installs LinuxNode10) Installs LinuxNode10 succeeded
Details
facebook.create-react-app (Installs LinuxNode12) Installs LinuxNode12 succeeded
Details
facebook.create-react-app (Kitchensink LinuxNode10) Kitchensink LinuxNode10 succeeded
Details
facebook.create-react-app (Kitchensink LinuxNode12) Kitchensink LinuxNode12 succeeded
Details
facebook.create-react-app (KitchensinkEject LinuxNode10) KitchensinkEject LinuxNode10 succeeded
Details
facebook.create-react-app (KitchensinkEject LinuxNode12) KitchensinkEject LinuxNode12 succeeded
Details
facebook.create-react-app (OldNode) OldNode succeeded
Details
facebook.create-react-app (Simple LinuxNode10) Simple LinuxNode10 succeeded
Details
facebook.create-react-app (Simple LinuxNode12) Simple LinuxNode12 succeeded
Details
netlify/create-react-app/deploy-preview Docs deploy preview succeeded
Details
v4 automation moved this from In progress to Done Jun 11, 2020
@ianschmitz
Copy link
Collaborator

@ianschmitz ianschmitz commented Jun 11, 2020

Thanks a ton @housseindjirdeh! Much appreciated.

@housseindjirdeh
Copy link
Contributor Author

@housseindjirdeh housseindjirdeh commented Jun 12, 2020

Awesome thanks all! So happy to see this land :)

@lock lock bot locked and limited conversation to collaborators Jun 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
v4
  
Done
Linked issues

Successfully merging this pull request may close these issues.

6 participants
You can’t perform that action at this time.
X Tutup