X Tutup
The Wayback Machine - https://web.archive.org/web/20250519194556/https://github.com/angular/angular/pull/45718
Skip to content

[11.2.x] build: updates to account for github primary branch rename #45718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[11.2.x] build: updates to account for github primary branch rename #45718

wants to merge 1 commit into from

Conversation

devversion
Copy link
Member

Patch port of #45715

@devversion
build: updates to account for github primary branch rename [v11]
841085e 
This is the commit accounting for the Github primary branch
rename when we actually perform the update.

We have three change phases: Prepare, Direct, Cleanup. This commit
is for the `direct` phase.

Note the version of ng-dev used in this LTS branch does not properly
support custom primary branches, but this should be non-relevant here
because this commit will only land in a version branch (11.2.x)
@devversion devversion changed the title build: updates to account for github primary branch rename [v11] [11.2.x] build: updates to account for github primary branch rename Apr 21, 2022
@devversion
Copy link
Member Author

Note: Test failures are still unrelated, similar to the failures we saw when landing the prep changes in the v11 LTS branch.

@dylhunn dylhunn added the area: dev-infra Issues related to Angular's own dev infra (build, test, CI, releasing) label Apr 28, 2022
@ngbot ngbot bot added this to the Backlog milestone Apr 28, 2022
@josephperrott josephperrott added action: merge The PR is ready for merge by the caretaker target: lts This PR is targeting a version currently in long-term support labels Apr 28, 2022
@ngbot
Copy link

ngbot bot commented Apr 28, 2022

I see that you just added the action: merge label, but the following checks are still failing:
    failure status "ci/angular: size" is failing
    failure status "ci/circleci: test" is failing
    failure status "ci/circleci: test_docs_examples" is failing
    failure status "ci/circleci: test_docs_examples_viewengine" is failing
    pending status "pullapprove" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

josephperrott
josephperrott approved these changes Apr 28, 2022
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephperrott josephperrott marked this pull request as ready for review April 28, 2022 17:27
@pullapprove pullapprove bot requested a review from gkalpak April 28, 2022 17:27
@josephperrott
Copy link
Member

This PR was merged into the repository by commit 7cd79b8.

josephperrott pushed a commit that referenced this pull request Apr 28, 2022
@devversion @josephperrott
build: updates to account for github primary branch rename [v11] (#45718
7cd79b8 
)

This is the commit accounting for the Github primary branch
rename when we actually perform the update.

We have three change phases: Prepare, Direct, Cleanup. This commit
is for the `direct` phase.

Note the version of ng-dev used in this LTS branch does not properly
support custom primary branches, but this should be non-relevant here
because this commit will only land in a version branch (11.2.x)

PR Close #45718
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@josephperrott josephperrott josephperrott approved these changes

@gkalpak gkalpak Awaiting requested review from gkalpak

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: dev-infra Issues related to Angular's own dev infra (build, test, CI, releasing) target: lts This PR is targeting a version currently in long-term support
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
3 participants
@devversion @josephperrott @dylhunn
X Tutup