bpo-34088: sndhdr.what() doesn't fail on bad input. by davidawad · Pull Request #8319 · python/cpython

davidawad · 2018-07-17T18:12:41Z

What this is

This is a very small fix for sndhdr.py so it can take bad input and not croak. This was originally reported by Jussi Judin on BPO here.

To reproduce this these crashes you can try the following examples:

$ echo UklGRjAwMDBXQVZFZm10IDAwMDABADAwMDAwMDAwMDAwMDAw | python3.7 -mbase64 -d > in.file
$ python3.7 sndhdr/test.py in.file
Traceback (most recent call last):
  File "sndhdr/test.py", line 4, in <module>
    sndhdr.what(sys.argv[1])
  File "/tmp/python-3.7-bin/lib/python3.7/sndhdr.py", line 54, in what
    res = whathdr(filename)
  File "/tmp/python-3.7-bin/lib/python3.7/sndhdr.py", line 63, in whathdr
    res = tf(h, f)
  File "/tmp/python-3.7-bin/lib/python3.7/sndhdr.py", line 163, in test_wav
    w = wave.open(f, 'r')
  File "/tmp/python-3.7-bin/lib/python3.7/wave.py", line 510, in open
    return Wave_read(f)
  File "/tmp/python-3.7-bin/lib/python3.7/wave.py", line 164, in __init__
    self.initfp(f)
  File "/tmp/python-3.7-bin/lib/python3.7/wave.py", line 153, in initfp
    chunk.skip()
  File "/tmp/python-3.7-bin/lib/python3.7/chunk.py", line 160, in skip
    self.file.seek(n, 1)
  File "/tmp/python-3.7-bin/lib/python3.7/chunk.py", line 113, in seek
    raise RuntimeError
RuntimeError

Another second crash comes from sndhdr module itself (again base64 encoded data is first decoded on command line):

$ echo AAA= | python3.7 -mbase64 -d > in.file
$ python3.7 sndhdr/test.py in.fileTraceback (most recent call last):
  File "sndhdr/test.py", line 4, in <module>
    sndhdr.what(sys.argv[1])
  File "/tmp/python-3.7-bin/lib/python3.7/sndhdr.py", line 54, in what
    res = whathdr(filename)
  File "/tmp/python-3.7-bin/lib/python3.7/sndhdr.py", line 63, in whathdr
    res = tf(h, f)
  File "/tmp/python-3.7-bin/lib/python3.7/sndhdr.py", line 192, in test_sndr
    rate = get_short_le(h[2:4])
  File "/tmp/python-3.7-bin/lib/python3.7/sndhdr.py", line 213, in get_short_le
    return (b[1] << 8) | b[0]
IndexError: index out of range

What this does

Right now this PR just handles some of the Exceptions caused by bad input and returns None based on @vstinner 's comments in the BPO.

How did I test this?

I ran the unit tests and retried the test cases from the bpo post.

(cpython-venv) [ david@lithium ]  ~/Projects/PYTHON/cpython
$>coverage run --pylib Lib/test/test_sndhdr.py
..
----------------------------------------------------------------------
Ran 2 tests in 0.005s

OK
(cpython-venv) [ david@lithium ]  ~/Projects/PYTHON/cpython
$>

Quick questions

So I have two questions about how this should be handled. This is my first python patch so I don't know if there's a better way to do this.

Should we only handle the specific exceptions that are created in these two examples? or is there a cleaner, more pythonic way to handle it?
Should I add test cases for bad inputs to the test_sndhdr.py file?

Thanks!

edit - sorry about the branch name. typo on my part.

https://bugs.python.org/issue34088

ammaraskar · 2018-07-17T18:46:59Z

Lib/sndhdr.py

+    try:
+        res = whathdr(filename)
+        return res
+    except RuntimeError as e:


Should we only handle the specific exceptions that are created in these two examples? or is there a cleaner, more pythonic way to handle it?

I think this should follow the pattern set out by sndhdr and have the exception catching be on a per-test basis. Take a look at this block for example:

cpython/Lib/sndhdr.py

Lines 75 to 91 in feabae9

def test_aifc(h, f):

import aifc

if not h.startswith(b'FORM'):

return None

if h[8:12] == b'AIFC':

fmt = 'aifc'

elif h[8:12] == b'AIFF':

fmt = 'aiff'

else:

return None

f.seek(0)

try:

a = aifc.open(f, 'r')

except (EOFError, aifc.Error):

return None

return (fmt, a.getframerate(), a.getnchannels(),

a.getnframes(), 8 * a.getsampwidth())

You should figure out what exceptions the individual tests code can throw and catch those specifically. As it stands now, its possible for a coding error like an out of bounds exception to be caught accidentally by your exception handler.

cool, in that case we already catch exactly those two errors, the RuntimeError and the IndexError caused by these bad files and catch them explicitly. I'll add some testcases to Lib/test_sndhdr.py and @you when it's done.

ammaraskar · 2018-07-17T18:47:48Z

Should I add test cases for bad inputs to the test_sndhdr.py file?

Yes, definitely add test cases.

serhiy-storchaka · 2018-07-17T19:01:24Z

whathdr() shouldn't raise exceptions too, except OSErrors when open or read a file. I concur with @ammaraskar, it is better to catch exceptions on a per-test basis.

And please don't make unrelated changes (like adding spaces or newlines).

davidawad · 2018-07-17T19:55:56Z

@ammaraskar @serhiy-storchaka just to be sure, are you referring to catching exceptions at the sndhdr.what() level? Or are you asking to add exception handling to the lower level test_<filetype>
functions here?

I've added some tests for the different types on inputs this could get, but I want to point out that something weird that I wanted some clarity on. Python hangs when you pass False here.

Python 3.8.0a0 (heads/master:28f07364f0, Jul 17 2018, 11:42:07)
[Clang 9.0.0 (clang-900.0.39.2)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import sndhdr
>>> sndhdr.what('NO')
>>> sndhdr.what(None)
>>> sndhdr.what(False)
# process hangs

The same thing happens for True. What's the right way to handle this? raise exception for boolean inputs?

Thanks.

ammaraskar · 2018-07-17T23:33:22Z

are you referring to catching exceptions at the sndhdr.what() level? Or are you asking to add exception handling to the lower level test_ functions here?

At the lower test_ level.

Python hangs when you pass False here. What's the right way to handle this? raise exception for boolean inputs?

Don't handle this case explicitly, what's happening here requires a bit of explanation, open() can apparently open file descriptors by their numbers. False is treated as 0 which opens up stdin for reading, that's why it appears to hang.

Moreover, your tests aren't really testing the primary thing addressed in the bug, which is random binary data. Please add a test that attempts to call sndhdr.what on the payloads provided in the bug ticket.

…test_functions

davidawad · 2018-07-20T16:34:21Z

@ammaraskar That's really interesting! I figured it was something like that because i'd pass other numbers like 5, 888, etc. and I'd get an OSError about a bad file descriptor. Good to know!

I added two different files based on the bug ticket with binary data described in the ticket, and added handlers for the exceptions they throw.

A few of the builds are still running but let me know if there's anything else i can do.

Does this warrant an addition to news.d?

tiran · 2018-07-28T09:42:46Z

Lib/sndhdr.py

+    try:
+        res = whathdr(filename)
+        return res
+    except (FileNotFoundError) as e:


Please remove the extra () and unused as e.

Why silence FileNotFoundError at first point?

@serhiy-storchaka This was my mistake. This exception really happens inside of whathdr(). I'll catch it there.

@serhiy-storchaka I also added unit tests specifically checking for bad input on both what() and whathdr()

I should have caught this bug when writing those tests. My bad on that, still trying to learn and get better here :)

tiran · 2018-07-28T09:44:08Z

Lib/sndhdr.py

+                    return SndHeaders(*res)
+        return None
+
+    except(TypeError) as e:


Same here, except TypeError

@tiran will do. definitely was silly to create e and not use it. thanks

tiran · 2018-07-28T09:44:53Z

Lib/sndhdr.py

+            rate = get_short_le(h[2:4])
+            if 4000 <= rate <= 25000:
+                return 'sndr', rate, 1, -1, 8
+    except (IndexError) as e:


bedevere-bot · 2018-07-28T09:45:22Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

And if you don't make the requested changes, you will be poked with soft cushions!

serhiy-storchaka · 2018-07-28T14:52:23Z

Lib/sndhdr.py

+    try:
+        res = whathdr(filename)
+        return res
+    except (FileNotFoundError) as e:


Why silence FileNotFoundError at first point?

serhiy-storchaka · 2018-07-28T14:56:55Z

Lib/sndhdr.py

+                    return SndHeaders(*res)
+        return None
+
+    except(TypeError) as e:


I think that no any exception should be ignored at the top level. Catch appropriate exceptions in corresponding test functions.

For example your change silences the error in sndhdr.what(None).

yes, definitely. My catch in sndhdr.what should really be happening here. I'll move it. Thanks!

serhiy-storchaka · 2018-07-28T14:57:26Z

Lib/sndhdr.py


 tests = []

+


Unrelated change.

This was a pep8 recommendation from a linting tool that I use. I'll remove it.

serhiy-storchaka · 2018-07-28T14:59:39Z

Lib/sndhdr.py

+        f.seek(0)
        w = wave.open(f, 'r')
-    except (EOFError, wave.Error):
+    except (EOFError,


Can't it be written in a single line?

In this case it's just the 4 error types, if you think it makes more sense to put them in one line I can definitely move them.

Just wondering why? Is it more pythonic to do it that way?

Because
it
is
better
to
not
split
a
line
without
a
need.

…s for whathdr.

davidawad · 2018-07-30T15:46:40Z

I have made the requested changes; please review again.

^^ comment for bot

bedevere-bot · 2018-07-30T15:46:42Z

Thanks for making the requested changes!

@tiran: please review the changes made to this pull request.

serhiy-storchaka

Please remove all unrelated changes and catch exceptions in proper places.

serhiy-storchaka · 2018-07-30T18:34:30Z

Lib/sndhdr.py

+                    return SndHeaders(*res)
+        return None
+
+    except (TypeError,


Don't catch TypeError here. Catch it in test functions.

So this TypeError is thrown when passing None to the open() call. That's specific to this function, would you prefer to just not catch it?

let me know whatever you'd prefer and i'll make the change.

When commenting out the try catch this is what happens in whathdr

>>> sndhdr.whathdr(None) Traceback (most recent call last): File "<stdin>", line 1, in <module> File "/Users/david/Projects/PYTHON/cpython/Lib/sndhdr.py", line 62, in whathdr with open(filename, 'rb') as f: TypeError: expected str, bytes or os.PathLike object, not NoneType >>>

I don't think you should catch it, from the traceback its very obvious what went wrong, since the documentation explicitly says what() works on files, it is expected to receive FileNotFound and invalid file name errors.

wholly agree. I'll make the change.

serhiy-storchaka · 2018-07-30T18:43:48Z

Lib/sndhdr.py

+        f.seek(0)
        w = wave.open(f, 'r')
-    except (EOFError, wave.Error):
+    except (EOFError,


Because
it
is
better
to
not
split
a
line
without
a
need.

serhiy-storchaka · 2018-07-30T18:56:55Z

Lib/sndhdr.py

    return (fmt, a.getframerate(), a.getnchannels(),
            a.getnframes(), 8 * a.getsampwidth())

+


This is not related change.

consider it gone!

serhiy-storchaka · 2018-07-30T18:58:17Z

Lib/sndhdr.py

+        return None
+
+    except (TypeError,
+            FileNotFoundError):


Don't catch FileNotFoundError.

bedevere-bot · 2018-07-30T19:01:40Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

davidawad · 2018-07-31T19:13:03Z

Alright, this was a really good learning experience. Thank you all for sticking with me and helping me make this change the right way. I think I've got all the changes requested at this point, but of course i'm happy to make more.

Two quick questions:

Would you prefer a rebase to compress all these commits into one since there's a lot of commits here?
Would it be possible for me to submit a separate style only PR on the sndhdr module to apply those PEP8 changes?

and for the bot:
I have made the requested changes; please review again

bedevere-bot · 2018-07-31T19:13:06Z

Thanks for making the requested changes!

@vstinner, @serhiy-storchaka, @tiran: please review the changes made to this pull request.

davidawad · 2018-09-10T18:04:39Z

Can anyone review this? It's been a while and I'd love to see it go in.

csabella · 2019-04-09T13:27:43Z

@tiran @serhiy-storchaka @vstinner Re-requesting review to hopefully push this one to be merged.

@davidair, you don't have to squash the commits as that is done upon merge. Also, we don't generally accept PRs that are just PEP8 changes as they create more noise in the git blame than benefit. Thank you for asking and wanting to improve Python! 🙂

serhiy-storchaka · 2019-04-09T14:59:18Z

Lib/test/test_sndhdr.py

+            filename = findfile(filename, subdir="sndhdrdata")
+
+            what = sndhdr.what(filename)
+            self.assertEqual(what, None)


Suggested change

self.assertEqual(what, None)

self.assertIsNone(what)

serhiy-storchaka · 2019-04-09T14:59:33Z

Lib/test/test_sndhdr.py

+            self.assertEqual(what, None)
+
+            whathdr = sndhdr.whathdr(filename)
+            self.assertEqual(whathdr, None)


Suggested change

self.assertEqual(whathdr, None)

self.assertIsNone(whathdr)

serhiy-storchaka · 2019-04-09T14:59:52Z

Lib/test/test_sndhdr.py

+            for tf in sndhdr.tests:
+                with open(filename, 'rb') as f:
+                    h = f.read(512)
+                    self.assertEqual(tf(h, f), None)


Suggested change

self.assertEqual(tf(h, f), None)

self.assertIsNone(tf(h, f))

serhiy-storchaka · 2019-04-09T15:04:24Z

Lib/wave.py

-            chunk.skip()
+            try:
+                chunk.skip()
+            except RuntimeError:


Why this was added? Tests are passed without this change.

I don't think they actually pass without catching this. It's been a while so looking at this again I get the following issue when running these tests without this fix.

david@lithium ~/P/P/c/L/test>pso-34088>../../python.exe test_sndhdr.py 18:22:08 E.. ====================================================================== ERROR: test_badinputs (__main__.TestFormats) ---------------------------------------------------------------------- Traceback (most recent call last): File "test_sndhdr.py", line 35, in test_badinputs what = sndhdr.what(filename) File "/Users/david/Projects/PYTHON/cpython/Lib/sndhdr.py", line 54, in what res = whathdr(filename) File "/Users/david/Projects/PYTHON/cpython/Lib/sndhdr.py", line 63, in whathdr res = tf(h, f) File "/Users/david/Projects/PYTHON/cpython/Lib/sndhdr.py", line 163, in test_wav w = wave.open(f, 'r') File "/Users/david/Projects/PYTHON/cpython/Lib/wave.py", line 510, in open return Wave_read(f) File "/Users/david/Projects/PYTHON/cpython/Lib/wave.py", line 164, in __init__ self.initfp(f) File "/Users/david/Projects/PYTHON/cpython/Lib/wave.py", line 153, in initfp chunk.skip() File "/Users/david/Projects/PYTHON/cpython/Lib/chunk.py", line 160, in skip self.file.seek(n, 1) File "/Users/david/Projects/PYTHON/cpython/Lib/chunk.py", line 113, in seek raise RuntimeError RuntimeError ---------------------------------------------------------------------- Ran 3 tests in 0.010s FAILED (errors=1)

I believe at the time I thought that this file should have reported the runtime error if it failed to skip through a wav file that was poorly formatted.

Given I'm not very experienced at being a principled programmer; @serhiy-storchaka where do you think is the best place to catch this error or deal with the tests failing on the bad input files?

davidair · 2019-04-09T20:24:28Z

@tiran @serhiy-storchaka @vstinner Re-requesting review to hopefully push this one to be merged.

@davidair, you don't have to squash the commits as that is done upon merge. Also, we don't generally accept PRs that are just PEP8 changes as they create more noise in the git blame than benefit. Thank you for asking and wanting to improve Python! 🙂

Probably wrong David - did you mean @davidawad?

csabella · 2019-04-09T20:54:31Z

Probably wrong David - did you mean @davidawad?

Yes, sorry about that and thank you for including the correct David.

davidawad · 2019-05-01T22:43:23Z

Definitely, thanks for bringing this back to my attention @csabella . I really want to see this somewhat simple PR get merged as it's been a really good learning experience overall and i'd love to try to improve upon this and help out on some of the other easier python issues as well.

@serhiy-storchaka If I didn't make it clear last year I really appreciate your patience and advice it's been really helpful.

I've made the changes but I want to know what you all think the correct way is to deal with the chunk.skip() issue mentioned here: #8319 (comment)

I've made the other changes for the unit tests.

serhiy-storchaka · 2019-05-19T19:46:02Z

Both input1.bad and input2.bad are empty files.

Since all errors are due to truncation, I suggest you to use the following test:

    def test_truncated(self):
        for filename, expected in SAMPLES:
            filename = findfile(filename, subdir="sndhdrdata")
            with open(filename, 'rb') as f:
                data = f.read()
            self.addCleanup(unlink, TESTFN)
            with self.subTest(filename=filename):
                for i in range(len(data)):
                    with open(TESTFN, 'wb') as f:
                        f.write(data[:i])
                    what = sndhdr.what(TESTFN)
                    if what is not None:
                        self.assertEqual(what, expected)
                    for tf in sndhdr.tests:
                        with open(TESTFN, 'rb') as f:
                            t = tf(data[:i], f)
                            if t is not None:
                                self.assertEqual(t, what)

SAMPLES is the same as in test_data, TESTFN and unlink are imported from test.support.

Currently this test fails. Make it passing.

Maybe the simpler test is enough: self.assertEqual(what[0], expected[0]) instead of self.assertEqual(what, expected), but it would be better to achieve the success of the more strong test.

davidawad · 2019-06-05T22:35:37Z

I have imported that test and i'm able to correct some of these failures but I don't really understand exactly how these audio formats work.

Is there documentation I can read to get a better understanding of how to handle some of the failure cases this test causes?

For example he's a fauilure I'm not really sure the right way to fix.

======================================================================
FAIL: test_truncated (__main__.TestFormats) (filename='/Users/david/Projects/PYTHON/cpython/Lib/test/sndhdrdata/sndhdr.au')
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test/test_sndhdr.py", line 69, in test_truncated
    self.assertEqual(what, expected)
AssertionError: SndHeaders(filetype='au', framerate=0, nchannels=0, nframes=-1, sampwidth='?') != ('au', 44100, 2, 5.0, 16)

I'm not sure how to adjust the test_au() function in sndhdr.py in order to get this test to pass.

Can you show me how you'd do it or what I should read to understand?

Thanks for any help

serhiy-storchaka · 2019-06-07T04:30:21Z

In general you need to catch all expected errors in test_* functions and return None. You have to remove if len(b) < 4: from get_long_be() and catch an IndexError in functions that use it.

serhiy-storchaka · 2019-06-07T04:35:18Z

Alternatively you can add if len(h) < 24: return None in test_au() and similar checks in other functions. Then you could use int.from_bytes() instead of get_long_be() and friends.

taleinat · 2019-08-05T10:35:05Z

Ping, @davidawad!

taleinat · 2020-09-19T20:25:04Z

Ping, @davidawad!

davidawad · 2020-09-22T15:24:10Z

@taleinat admittedly I gave up on this after a while. I'll try to take another look this weekend and see if I can figure it out.

It was tricky just because I didn't have anyone to really ask questions to but I'm sure we can get it done.

taleinat · 2020-09-22T19:22:16Z

@davidawad, please feel free to ask any questions! You can do so here, on the b.p.o. issue, on the Python IRC or Zulip channels, or on the various mailing lists.

hugovk · 2022-04-12T06:16:12Z

Note the sndhdr module is deprecated in 3.11 and set for removal in 3.13.

See PEP 594 – Removing dead batteries from the standard library and #91217.

kumaraditya303 · 2022-04-14T13:01:17Z

Closing as the module is deprecated.

davidawad added 2 commits July 17, 2018 13:33

CHORE: whitespace, newlines, PEP8 compliance

836ff67

FIX: adding excepts for runtime errors on bad input.

168df4e

the-knights-who-say-ni added the CLA signed label Jul 17, 2018

bedevere-bot added the awaiting review label Jul 17, 2018

ammaraskar requested changes Jul 17, 2018

View reviewed changes

bedevere-bot added awaiting core review and removed awaiting review labels Jul 17, 2018

FIX: catching additional exceptions, and writing test cases for them

f61fb8c

davidawad added 3 commits July 20, 2018 11:38

TEST: adding binary files for testing bad inputs

daa7756

FEAT: adding better test cases and exception handling to lower level …

2ceba62

…test_functions

Removing base64 and fixing extra newlines

78a40c6

extra newline

b8d94b0

tiran requested changes Jul 28, 2018

View reviewed changes

bedevere-bot added awaiting changes and removed awaiting core review labels Jul 28, 2018

serhiy-storchaka reviewed Jul 28, 2018

View reviewed changes

FIX: moving Error handling for what to whathdr, adding bad input test…

32f80ed

…s for whathdr.

bedevere-bot added awaiting change review and removed awaiting changes labels Jul 30, 2018

serhiy-storchaka requested changes Jul 30, 2018

View reviewed changes

bedevere-bot removed the awaiting change review label Jul 30, 2018

bedevere-bot added awaiting change review and removed awaiting changes labels Jul 31, 2018

csabella requested review from serhiy-storchaka, tiran and vstinner April 9, 2019 13:23

serhiy-storchaka reviewed Apr 9, 2019

View reviewed changes

FIX: undo change in wave.py

a9e0513

davidawad force-pushed the pso-34088 branch from 4bc21d2 to a9e0513 Compare May 1, 2019 22:14

FIX: sndhdr test suggestion

59a8fe3

csabella requested a review from serhiy-storchaka May 19, 2019 02:12

tiran removed their request for review April 18, 2021 07:18

Barro mannequin mentioned this pull request Apr 12, 2022

[EASY] sndhdr.what() throws exceptions on unknown files #78269

Closed

kumaraditya303 closed this Apr 14, 2022

Jan	FEB	Mar
	17
2025	2026	2027

	def test_aifc(h, f):
	import aifc
	if not h.startswith(b'FORM'):
	return None
	if h[8:12] == b'AIFC':
	fmt = 'aifc'
	elif h[8:12] == b'AIFF':
	fmt = 'aiff'
	else:
	return None
	f.seek(0)
	try:
	a = aifc.open(f, 'r')
	except (EOFError, aifc.Error):
	return None
	return (fmt, a.getframerate(), a.getnchannels(),
	a.getnframes(), 8 * a.getsampwidth())

Uh oh!

Conversation

davidawad commented Jul 17, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What this is

What this does

How did I test this?

Quick questions

Uh oh!

Choose a reason for hiding this comment

Uh oh!

davidawad Jul 17, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ammaraskar commented Jul 17, 2018

Uh oh!

serhiy-storchaka commented Jul 17, 2018

Uh oh!

davidawad commented Jul 17, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ammaraskar commented Jul 17, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

davidawad commented Jul 20, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bedevere-bot commented Jul 28, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

davidawad Jul 30, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

davidawad commented Jul 30, 2018

Uh oh!

bedevere-bot commented Jul 30, 2018

Uh oh!

serhiy-storchaka left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

davidawad Jul 30, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

davidawad commented Jul 17, 2018 •

edited

Loading

davidawad Jul 17, 2018 •

edited

Loading

davidawad commented Jul 17, 2018 •

edited

Loading

ammaraskar commented Jul 17, 2018 •

edited

Loading

davidawad commented Jul 20, 2018 •

edited

Loading

davidawad Jul 30, 2018 •

edited

Loading

davidawad Jul 30, 2018 •

edited

Loading

davidawad commented Jul 31, 2018 •

edited

Loading