X Tutup
The Wayback Machine - https://web.archive.org/web/20220323092636/https://github.com/nodejs/node/pull/38244
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix typo in repl.md #38244

Merged
merged 1 commit into from Apr 17, 2021
Merged

doc: fix typo in repl.md #38244

merged 1 commit into from Apr 17, 2021

Conversation

arkerone
Copy link
Contributor

@arkerone arkerone commented Apr 15, 2021

I found a typo in REPL documentation :

entires -> entries

@nodejs-github-bot nodejs-github-bot added doc repl labels Apr 15, 2021
Copy link
Member

@jasnell jasnell left a comment

Fast track? Please 👍🏻

@jasnell jasnell added the fast-track label Apr 15, 2021
targos
targos approved these changes Apr 15, 2021
@jasnell
Copy link
Member

@jasnell jasnell commented Apr 15, 2021

Unrelated flaky failure in github CI... will land once I can get a good run.

lpinca
lpinca approved these changes Apr 15, 2021
@marsonya marsonya added the author ready label Apr 16, 2021
Trott
Trott approved these changes Apr 17, 2021
"entires" -> "entries"

PR-URL: nodejs#38244
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@aduh95
Copy link
Contributor

@aduh95 aduh95 commented Apr 17, 2021

Landed in e541032

@aduh95 aduh95 merged commit e541032 into nodejs:master Apr 17, 2021
13 checks passed
@arkerone arkerone deleted the doc/fix-typo-repl branch Apr 21, 2021
targos added a commit that referenced this issue May 1, 2021
"entires" -> "entries"

PR-URL: #38244
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
danielleadams added a commit that referenced this issue May 8, 2021
"entires" -> "entries"

PR-URL: #38244
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready doc fast-track repl
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

X Tutup