X Tutup
The Wayback Machine - https://web.archive.org/web/20210814135034/https://github.com/nodejs/node/pull/38210
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove common.disableCrashOnUnhandledRejection #38210

Closed

Conversation

@targos
Copy link
Member

@targos targos commented Apr 12, 2021

Use the --unhandled-rejections=none CLI flag instead.

Use the --unhandled-rejections=none CLI flag instead.
@Trott
Trott approved these changes Apr 13, 2021
@targos
Copy link
Member Author

@targos targos commented Apr 14, 2021

Landed in 05df701

@targos targos closed this Apr 14, 2021
@targos targos deleted the targos:remove-disableCrashOnUnhandledRejection branch Apr 14, 2021
targos added a commit that referenced this pull request Apr 14, 2021
Use the --unhandled-rejections=none CLI flag instead.

PR-URL: #38210
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs added a commit that referenced this pull request Apr 15, 2021
Use the --unhandled-rejections=none CLI flag instead.

PR-URL: #38210
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
X Tutup