X Tutup
The Wayback Machine - https://web.archive.org/web/20210814021428/https://github.com/nodejs/node/pull/38202
Skip to content

/ node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test,doc: fix https agent minVersion/maxVersion test and docs #38202

Closed
wants to merge 3 commits into from
Closed

test,doc: fix https agent minVersion/maxVersion test and docs #38202

wants to merge 3 commits into from

Conversation

@Trott
Copy link
Member

@Trott Trott commented Apr 11, 2021 •
edited 

test: fix test-https-agent-additional-options.js

`value` was always being assigned to an `undefined` property of an
Array. Thus, the assertions that depended on `value` being defined were
never being checked. Assign `value` the correct...er...value.

test add tests for missing https agent options

Add test that minVersion and maxVersion options are accepted. This
should complete coverage for lib/https.js.

Refs: https://codecov.io/gh/nodejs/node/src/ec0dcd720e10831b3e783b415c5dc011ed5be2f8/lib/https.js

doc: revise TLS minVersion/maxVersion text

Minor changes mostly to improve compliance with our style guide.
@Trott
test: fix test-https-agent-additional-options.js
543a9a0 
`value` was always being assigned to an `undefined` property of an
Array. Thus, the assertions that depended on `value` being defined were
never being checked. Assign `value` the correct...er...value.
@nodejs-github-bot

This comment has been hidden.

Sign in to view
@benjamingr
benjamingr approved these changes Apr 11, 2021
View changes
@jasnell
jasnell approved these changes Apr 11, 2021
View changes
@nodejs-github-bot

This comment has been hidden.

Sign in to view
@lpinca
lpinca approved these changes Apr 11, 2021
View changes
@lpinca
Copy link
Member

@lpinca lpinca commented Apr 11, 2021

"shoudl" typo in second commit message.
Trott added 2 commits Apr 11, 2021
@Trott
test add tests for missing https agent options
74d62ff 
Add test that minVersion and maxVersion options are accepted. This
should complete coverage for lib/https.js.

Refs: https://codecov.io/gh/nodejs/node/src/ec0dcd720e10831b3e783b415c5dc011ed5be2f8/lib/https.js
@Trott
doc: revise TLS minVersion/maxVersion text
55bada0 
Minor changes mostly to improve compliance with our style guide.
@Trott Trott force-pushed the Trott:fix-agent-test branch from b5a7c12 to 55bada0 Apr 11, 2021
@nodejs-github-bot

This comment has been hidden.

Sign in to view
@nodejs-github-bot

This comment has been hidden.

Sign in to view
@nodejs-github-bot
Copy link

@nodejs-github-bot nodejs-github-bot commented Apr 12, 2021 •
edited by jasnell

CI: https://ci.nodejs.org/job/node-test-pull-request/37391/ 💚
@marsonya
marsonya approved these changes Apr 13, 2021
View changes
jasnell added a commit that referenced this pull request Apr 14, 2021
@Trott @jasnell
test: fix test-https-agent-additional-options.js
4ad8e83 
`value` was always being assigned to an `undefined` property of an
Array. Thus, the assertions that depended on `value` being defined were
never being checked. Assign `value` the correct...er...value.

PR-URL: #38202
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
jasnell added a commit that referenced this pull request Apr 14, 2021
@Trott @jasnell
test: add tests for missing https agent options
18c9913 
Add test that minVersion and maxVersion options are accepted. This
should complete coverage for lib/https.js.

Refs: https://codecov.io/gh/nodejs/node/src/ec0dcd720e10831b3e783b415c5dc011ed5be2f8/lib/https.js

PR-URL: #38202
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
jasnell added a commit that referenced this pull request Apr 14, 2021
@Trott @jasnell
doc: revise TLS minVersion/maxVersion text
b4363f7 
Minor changes mostly to improve compliance with our style guide.

PR-URL: #38202
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@jasnell
Copy link
Member

@jasnell jasnell commented Apr 14, 2021

Landed in 09c9e5d...b4363f7
@jasnell jasnell closed this Apr 14, 2021
BethGriggs added a commit that referenced this pull request Apr 15, 2021
@Trott @BethGriggs
test: fix test-https-agent-additional-options.js
9d8d9c3 
`value` was always being assigned to an `undefined` property of an
Array. Thus, the assertions that depended on `value` being defined were
never being checked. Assign `value` the correct...er...value.

PR-URL: #38202
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BethGriggs added a commit that referenced this pull request Apr 15, 2021
@Trott @BethGriggs
test: add tests for missing https agent options
96f1052 
Add test that minVersion and maxVersion options are accepted. This
should complete coverage for lib/https.js.

Refs: https://codecov.io/gh/nodejs/node/src/ec0dcd720e10831b3e783b415c5dc011ed5be2f8/lib/https.js

PR-URL: #38202
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BethGriggs added a commit that referenced this pull request Apr 15, 2021
@Trott @BethGriggs
doc: revise TLS minVersion/maxVersion text
0d2c05c 
Minor changes mostly to improve compliance with our style guide.

PR-URL: #38202
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Apr 16, 2021
Merged
targos added a commit that referenced this pull request May 1, 2021
@Trott @targos
test: fix test-https-agent-additional-options.js
796007b 
`value` was always being assigned to an `undefined` property of an
Array. Thus, the assertions that depended on `value` being defined were
never being checked. Assign `value` the correct...er...value.

PR-URL: #38202
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos added a commit that referenced this pull request May 1, 2021
@Trott @targos
test: add tests for missing https agent options
ae44e5f 
Add test that minVersion and maxVersion options are accepted. This
should complete coverage for lib/https.js.

Refs: https://codecov.io/gh/nodejs/node/src/ec0dcd720e10831b3e783b415c5dc011ed5be2f8/lib/https.js

PR-URL: #38202
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos added a commit that referenced this pull request May 1, 2021
@Trott @targos
doc: revise TLS minVersion/maxVersion text
5dfe5af 
Minor changes mostly to improve compliance with our style guide.

PR-URL: #38202
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
danielleadams added a commit that referenced this pull request May 8, 2021
@Trott @danielleadams
test: fix test-https-agent-additional-options.js
553cd85 
`value` was always being assigned to an `undefined` property of an
Array. Thus, the assertions that depended on `value` being defined were
never being checked. Assign `value` the correct...er...value.

PR-URL: #38202
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams added a commit that referenced this pull request May 8, 2021
@Trott @danielleadams
test: add tests for missing https agent options
b1084a4 
Add test that minVersion and maxVersion options are accepted. This
should complete coverage for lib/https.js.

Refs: https://codecov.io/gh/nodejs/node/src/ec0dcd720e10831b3e783b415c5dc011ed5be2f8/lib/https.js

PR-URL: #38202
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams added a commit that referenced this pull request May 8, 2021
@Trott @danielleadams
doc: revise TLS minVersion/maxVersion text
2cbcffe 
Minor changes mostly to improve compliance with our style guide.

PR-URL: #38202
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell

@benjamingr benjamingr

@lpinca lpinca

@marsonya marsonya

Assignees
No one assigned
Labels
author ready needs-ci
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
@Trott @nodejs-github-bot @lpinca @jasnell @benjamingr @marsonya @PoojaDurgad
X Tutup