X Tutup
The Wayback Machine - https://web.archive.org/web/20220323050554/https://github.com/nodejs/node/pull/37176
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vm: add import assertion support #37176

Merged
merged 1 commit into from Mar 23, 2021
Merged

vm: add import assertion support #37176

merged 1 commit into from Mar 23, 2021

Conversation

devsnek
Copy link
Member

@devsnek devsnek commented Feb 1, 2021

Just a draft until our V8 is new enough to support this.

@nodejs-github-bot nodejs-github-bot added c++ vm labels Feb 1, 2021
@devsnek devsnek marked this pull request as draft Feb 1, 2021
@devsnek devsnek added the esm label Feb 1, 2021
cjihrig
cjihrig reviewed Feb 1, 2021
View changes
doc/api/vm.md Outdated Show resolved Hide resolved
addaleax
addaleax approved these changes Feb 4, 2021
View changes
Copy link
Member

@addaleax addaleax left a comment

LGTM (with a comment to avoid crashing in cases of prototype pollution addressed)

src/module_wrap.cc Show resolved Hide resolved
@devsnek devsnek marked this pull request as ready for review Mar 23, 2021
@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Mar 23, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/36921/

targos
targos approved these changes Mar 23, 2021
View changes
@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Mar 23, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/36928/

@devsnek
vm: add import assertion support
26eed3e 
PR-URL: nodejs#37176
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@devsnek devsnek merged commit 26eed3e into nodejs:master Mar 23, 2021
12 of 13 checks passed
@devsnek devsnek deleted the vm-import-assertion branch Mar 23, 2021
ruyadorno added a commit that referenced this issue Mar 24, 2021
@devsnek @ruyadorno
vm: add import assertion support
4f354b0 
PR-URL: #37176
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@ruyadorno
Copy link
Member

@ruyadorno ruyadorno commented Mar 30, 2021

hi @devsnek this commit is breaking make cctest in v15.x-staging - should it be backported to v15.x?

@devsnek
Copy link
Member Author

@devsnek devsnek commented Mar 30, 2021

@ruyadorno nope! its stuck to the v8 version in master 😄

@targos targos added dont-land-on-v10.x dont-land-on-v12.x dont-land-on-v14.x and removed backport-requested-v15.x labels Mar 30, 2021
@BethGriggs BethGriggs mentioned this pull request Apr 12, 2021
Merged
@aduh95 aduh95 mentioned this pull request Oct 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig

@addaleax addaleax

@targos targos

Assignees
No one assigned
Labels
c++ dont-land-on-v12.x dont-land-on-v14.x esm vm
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet
6 participants
@devsnek @nodejs-github-bot @ruyadorno @addaleax @targos @cjihrig
X Tutup