X Tutup
The Wayback Machine - https://web.archive.org/web/20210813191740/https://github.com/nodejs/node/pull/37151
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove outdated V8 flag #37151

Closed
wants to merge 1 commit into from
Closed

test: remove outdated V8 flag #37151

wants to merge 1 commit into from

Conversation

@targos
Copy link
Member

@targos targos commented Jan 30, 2021

The flag is going to be removed upstream in V8 9.0.

Refs: v8/v8@0a480c3

The flag is going to be removed upstream in V8 9.0.

Refs: v8/v8@0a480c3
Copy link
Member

@richardlau richardlau left a comment

I assume we want to keep the flag on the older V8 versions and don’t want this backported?

@Trott
Trott approved these changes Jan 31, 2021
targos added a commit that referenced this pull request Feb 2, 2021
The flag is going to be removed upstream in V8 9.0.

Refs: v8/v8@0a480c3

PR-URL: #37151
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@targos
Copy link
Member Author

@targos targos commented Feb 2, 2021

Landed in 501ae0e

@targos targos closed this Feb 2, 2021
@targos targos deleted the targos:remove-v8-flag branch Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

10 participants
X Tutup