build: enable ASLR (PIE) on OS X

After conducting several benchmarks, I noticed performance losses of 5-10%. As OS X is not a performance critical platform, as already mentioned by @bnoordhuis, I have removed the -no_pie flag at least for this platform. I'd love to enable PIE for other platforms if the 5-10% speed loss is not too high. I would be happy to hear your opinion on this. Refs: #33425 PR-URL: #35704 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
nodejs · Nov 17, 2020 · 8d6b74d3474080bd29dd698f55e88aba17c6a69e · 8d6b74d
1 parent fff25a0
commit 8d6b74d3474080bd29dd698f55e88aba17c6a69e
Unified Split

Showing with 1 addition and 2 deletions.

+1 −2 common.gypi
diff --git a/common.gypi b/common.gypi
@@ -495,8 +495,7 @@
           ['_type!="static_library"', {
             'xcode_settings': {
               'OTHER_LDFLAGS': [
-                '-Wl,-no_pie',
-                '-Wl,-search_paths_first',
+                '-Wl,-search_paths_first'
               ],
             },
           }],