X Tutup
The Wayback Machine - https://web.archive.org/web/20220319114834/https://github.com/nodejs/node/commit/18c9913ce1
Skip to content
Permalink
Browse files
test: add tests for missing https agent options
Add test that minVersion and maxVersion options are accepted. This
should complete coverage for lib/https.js.

Refs: https://codecov.io/gh/nodejs/node/src/ec0dcd720e10831b3e783b415c5dc011ed5be2f8/lib/https.js

PR-URL: #38202
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
  • Loading branch information
Trott authored and jasnell committed Apr 14, 2021
1 parent 4ad8e83 commit 18c9913ce18135953ef1ac02ded8604de9f42e2c
Showing with 2 additions and 0 deletions.
  1. +2 −0 test/parallel/test-https-agent-additional-options.js
@@ -36,6 +36,8 @@ const updatedValues = new Map([
['dhparam', fixtures.readKey('dh2048.pem')],
['ecdhCurve', 'secp384r1'],
['honorCipherOrder', true],
['minVersion', 'TLSv1.1'],
['maxVersion', 'TLSv1.3'],
['secureOptions', crypto.constants.SSL_OP_CIPHER_SERVER_PREFERENCE],
['secureProtocol', 'TLSv1_1_method'],
['sessionIdContext', 'sessionIdContext'],

0 comments on commit 18c9913

Please sign in to comment.
X Tutup