X Tutup
The Wayback Machine - https://web.archive.org/web/20220422033512/https://github.com/python/cpython/pull/91599
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-69093: Add mapping protocol support to sqlite3.Blob #91599

Merged

Conversation

Copy link
Contributor

@erlend-aasland erlend-aasland commented Apr 16, 2022

Originally written by @palaviv in gh-271.

Authored-by: Aviv Palivoda palaviv@gmail.com
Co-authored-by: Erlend E. Aasland erlend.aasland@innova.no

@erlend-aasland
Copy link
Contributor Author

@erlend-aasland erlend-aasland commented Apr 16, 2022

Let's land GH-91561 first.

Authored-by: Aviv Palivoda <palaviv@gmail.com>
Co-authored-by: Erlend E. Aasland <erlend.aasland@innova.no>
@erlend-aasland erlend-aasland force-pushed the sqlite-blob-add-mapping-protocol branch from a84e0fb to 38b2cdb Compare Apr 16, 2022
@JelleZijlstra
Copy link
Member

@JelleZijlstra JelleZijlstra commented Apr 16, 2022

Let's land GH-91561 first.

Done, could you fix the conflict? I'll also review the code for this one now.

Modules/_sqlite/blob.c Outdated Show resolved Hide resolved
Modules/_sqlite/blob.c Outdated Show resolved Hide resolved
Modules/_sqlite/blob.c Show resolved Hide resolved
@erlend-aasland erlend-aasland marked this pull request as draft Apr 16, 2022
@erlend-aasland erlend-aasland marked this pull request as ready for review Apr 17, 2022
Doc/library/sqlite3.rst Outdated Show resolved Hide resolved
@JelleZijlstra JelleZijlstra self-requested a review Apr 18, 2022
Lib/test/test_sqlite3/test_dbapi.py Show resolved Hide resolved
Lib/test/test_sqlite3/test_dbapi.py Show resolved Hide resolved
Modules/_sqlite/blob.c Outdated Show resolved Hide resolved
…lMwI.rst

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@JelleZijlstra JelleZijlstra merged commit 29afb7d into python:main Apr 22, 2022
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants
X Tutup