X Tutup
The Wayback Machine - https://web.archive.org/web/20220519145012/https://github.com/python/cpython/pull/91805
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-91755: Document Py_IncRef and Py_DecRef as C function. #91805

Merged
merged 4 commits into from May 18, 2022

Conversation

CharlieZhao95
Copy link
Contributor

@CharlieZhao95 CharlieZhao95 commented Apr 22, 2022

Document Py_IncRef and Py_DecRef as C function in Reference Counting docs.

@bedevere-bot bedevere-bot added docs awaiting review labels Apr 22, 2022
@CharlieZhao95 CharlieZhao95 marked this pull request as draft Apr 22, 2022
@CharlieZhao95 CharlieZhao95 marked this pull request as ready for review Apr 22, 2022
@kumaraditya303 kumaraditya303 requested a review from encukou May 2, 2022
@erlend-aasland erlend-aasland requested a review from AlexWaygood May 16, 2022
@AlexWaygood
Copy link
Member

@AlexWaygood AlexWaygood commented May 17, 2022

I'm way out of my depth on this one, so I'll pass on reviewing, sorry :)

@AlexWaygood AlexWaygood requested review from JelleZijlstra and removed request for AlexWaygood May 17, 2022
Doc/c-api/refcounting.rst Outdated Show resolved Hide resolved
Doc/c-api/refcounting.rst Outdated Show resolved Hide resolved
@erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented May 18, 2022

Resolves #91755

(apparently, autolinking only works from OP...)

erlend-aasland and others added 2 commits May 18, 2022
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@erlend-aasland erlend-aasland merged commit 58a3d28 into python:main May 18, 2022
13 checks passed
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented May 18, 2022

Thanks @CharlieZhao95 for the PR, and @erlend-aasland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒🤖

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented May 18, 2022

GH-92916 is a backport of this pull request to the 3.11 branch.

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented May 18, 2022

GH-92917 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this issue May 18, 2022
…onGH-91805)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
(cherry picked from commit 58a3d28)

Co-authored-by: Charlie Zhao <zhaoyu_hit@qq.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue May 18, 2022
…onGH-91805)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
(cherry picked from commit 58a3d28)

Co-authored-by: Charlie Zhao <zhaoyu_hit@qq.com>
miss-islington added a commit that referenced this issue May 18, 2022
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
(cherry picked from commit 58a3d28)

Co-authored-by: Charlie Zhao <zhaoyu_hit@qq.com>
miss-islington added a commit that referenced this issue May 18, 2022
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
(cherry picked from commit 58a3d28)

Co-authored-by: Charlie Zhao <zhaoyu_hit@qq.com>
@erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented May 18, 2022

FTR, approved by Petr offline.

Copy link
Member

@vstinner vstinner left a comment

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants
X Tutup