X Tutup
The Wayback Machine - https://web.archive.org/web/20220309025438/https://github.com/python/cpython/pull/31642
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-46848: Move _PyBytes_Find() to internal C API #31642

Merged
merged 1 commit into from Mar 2, 2022

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Mar 2, 2022

Move _PyBytes_Find() and _PyBytes_ReverseFind() functions to the
internal C API.

bytesobject.c now includes pycore_bytesobject.h.

https://bugs.python.org/issue46848

Move _PyBytes_Find() and _PyBytes_ReverseFind() functions to the
internal C API.

bytesobject.c now includes pycore_bytesobject.h.
@vstinner
Copy link
Member Author

@vstinner vstinner commented Mar 2, 2022

@arhadthedev
Copy link
Contributor

@arhadthedev arhadthedev commented Mar 2, 2022

The issue number looks misprinted. bpo-46848 is Use optimized string search function in mmap.find() with no mention of _PyBytes_Find inside.

@sweeneyde
Copy link
Member

@sweeneyde sweeneyde commented Mar 2, 2022

The issue number looks misprinted. bpo-46848 is Use optimized string search function in mmap.find() with no mention of _PyBytes_Find inside.

GH-31625 introduced it, but it should have gone in the private API.

@vstinner vstinner merged commit b6b711a into python:main Mar 2, 2022
11 checks passed
@vstinner vstinner deleted the pycore_bytesobject branch Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
X Tutup