X Tutup
The Wayback Machine - https://web.archive.org/web/20260218020325/https://github.com/nodejs/docker-node/pull/1697
Skip to content

feat: Node.js 18.0.0#1697

Merged
SimenB merged 2 commits intonodejs:mainfrom
nschonni:node-18
Apr 20, 2022
Merged

feat: Node.js 18.0.0#1697
SimenB merged 2 commits intonodejs:mainfrom
nschonni:node-18

Conversation

@nschonni
Copy link
Member

@nschonni nschonni commented Apr 19, 2022

Fixes #1696

Description

Motivation and Context

Testing Details

Example Output(if appropriate)

Types of changes

  • Documentation
  • Version change (Update, remove or add more Node.js versions)
  • Variant change (Update, remove or add more variants, or versions of variants)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Others (non of above)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING.md document.
  • All new and existing tests passed.

@nschonni
Copy link
Member Author

nschonni commented Apr 19, 2022

@nodejs/docker I'm not sure why Stretch is failing, but since it's EOL in June, should it just be dropped?

@nschonni
Copy link
Member Author

nschonni commented Apr 19, 2022

Ah, looks like it's related to GLIBC 2.28 being needed

 #7 25.98 node: /lib/x86_64-linux-gnu/libm.so.6: version `GLIBC_2.27' not found (required by node)
#7 25.98 node: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.25' not found (required by node)
#7 25.98 node: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.28' not found (required by node)

I'm leaning towards just dropping stretch for this new release line (since we'll be removing it when it hits EOL in a month anyway)

@astellingwerf
Copy link

astellingwerf commented Apr 19, 2022

Those issues with stretch are likely caused/mentioned by nodejs/node#42351.

astellingwerf
astellingwerf reviewed Apr 19, 2022
View reviewed changes
18/bullseye/Dockerfile
ENV NODE_VERSION 18.0.0

RUN ARCH= && dpkgArch="$(dpkg --print-architecture)" \
&& case "${dpkgArch##*-}" in \
Copy link

@astellingwerf astellingwerf Apr 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a particular reason why the indentation in the full debian Docker files differs from that in the slim editions?

Copy link
Member Author

@nschonni nschonni Apr 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not particularly, it's just coming from the template file

SimenB
SimenB approved these changes Apr 20, 2022
View reviewed changes
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditching stretch seems reasonable.

docker-library/official-images#12158

We recommend that maintainers plan to remove any Stretch-based images on or before 2022-06-30.

@SimenB SimenB merged commit 9c4dbb2 into nodejs:main Apr 20, 2022
@nodejs-github-bot nodejs-github-bot mentioned this pull request Apr 20, 2022
Merged
@github-actions
Copy link

github-actions bot commented Apr 20, 2022

Created PR on the official-images repo (docker-library/official-images#12266). See https://github.com/docker-library/faq#an-images-source-changed-in-git-now-what if you are wondering when it will be available on the Docker Hub.

@nschonni nschonni deleted the node-18 branch April 20, 2022 05:20
@nschonni
Copy link
Member Author

nschonni commented Apr 20, 2022

D'oh, forgot to fudge the dates in version.json or properly fix it, since stackbrew.js is creating duplicate tags for the overlapping date ranges

@SimenB
Copy link
Member

SimenB commented Apr 20, 2022

@nschonni can you fix it?

@trentm trentm mentioned this pull request Apr 20, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SimenB SimenB SimenB approved these changes

+1 more reviewer

@astellingwerf astellingwerf astellingwerf left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support Node v18

3 participants

@nschonni @astellingwerf @SimenB
X Tutup