meta: move one or more collaborators to emeritus #42599
Conversation
nodejs-github-bot
added
meta
|
It seems the script doesn't take the date of addition of the collaborator into consideration (there is no way currently to factor date anyways). So if a collaborator was added recently and they are not active between the day they were added and the day the script was scheduled to run, the collaborator is considered as (erroneously) inactive. |
|
My last commit is 7 days ago. Is it because my email in commit info is different from readme？ |
That could be it, I think you'd need to add an entry in the .mailmap file so commits from both email address are counted by the bot. |
|
ping/FYI @boneskull |
Yes, the script looks for commits and reviews from the email address in the README. So if commits aren't from that email address and there is no .mailmap entry mapping the commit email to the email in the README, this can happen. I'll open a PR adding a .mailmap entry for you. |
|
Coincidentally, it was @boneskull that was the person who suggested an automated process for removing inactive collaborators in the first place. |
Refs: #42599 (comment) PR-URL: #42602 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Xuguang Mei <meixuguang@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Refs: nodejs#42599 (comment) PR-URL: nodejs#42602 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Xuguang Mei <meixuguang@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
marsonya
added
the
author ready
Refs: #42599 (comment) PR-URL: #42602 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Xuguang Mei <meixuguang@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Refs: #42599 (comment) PR-URL: #42602 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Xuguang Mei <meixuguang@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #42599 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Xuguang Mei <meixuguang@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Trott
force-pushed
the
actions/inactive-collaborators
branch
from
9d7ad89
to
2949249
Compare
|
Landed in 2949249 |
Refs: nodejs#42599 (comment) PR-URL: nodejs#42602 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Xuguang Mei <meixuguang@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: nodejs#42599 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Xuguang Mei <meixuguang@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This PR was generated by tools/find-inactive-collaborators.yml.