X Tutup
The Wayback Machine - https://web.archive.org/web/20220426171458/https://github.com/RustPython/RustPython/issues/3467
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add usedforsecurity optional keyword argument to hashlib functions #3467

Open
youknowone opened this issue Nov 28, 2021 · 2 comments
Open

Add usedforsecurity optional keyword argument to hashlib functions #3467

youknowone opened this issue Nov 28, 2021 · 2 comments
Labels
compat

Comments

@youknowone
Copy link
Member

@youknowone youknowone commented Nov 28, 2021

https://docs.python.org/3/library/hashlib.html

Changed in version 3.9: All hashlib constructors take a keyword-only argument usedforsecurity with default value True. A false value allows the use of insecure and blocked hashing algorithms in restricted environments. False indicates that the hashing algorithm is not used in a security context, e.g. as a non-cryptographic one-way compression function.

We can handle this in 2-steps.

  1. Adding an optional parameter usedforsecurity everywhere.
  2. Actually use the value.
@youknowone youknowone added good first issue compat labels Nov 28, 2021
@TeamTamoad
Copy link
Contributor

@TeamTamoad TeamTamoad commented Nov 28, 2021

I'll take this issue

@TeamTamoad
Copy link
Contributor

@TeamTamoad TeamTamoad commented Nov 30, 2021

The first step is completed and merged. #3474

  1. Adding an optional parameter usedforsecurity everywhere.

Anyone can take this issue and continue working on the second step

  1. Actually use the value.

@youknowone youknowone removed the good first issue label Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compat
Projects
None yet
Development

No branches or pull requests

2 participants
X Tutup