lib: unlink the next pointer for FixedQueue to avoid potential memory leaks
#42680
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure this is an existing problem since this is only used internally, unless you are saying definitively that there is an existing memory leak in node core? |
Yeah, that's what I mean 'potential' in the title.
Currently I only found this in test cases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
In the internal FixedQueue, once a FixedCircularBuffer is used out, it does not unlink the
nextpointer, thus if a variable references theheadortailfield of FixedQueue, it will cause a memory leak. I wrote a reproducing example here. Another way is to makeheadandtailfield private, but we need to modify the test cases intest/parallel/test-fixed-queue.js.