X Tutup
The Wayback Machine - https://web.archive.org/web/20220509083731/https://github.com/nodejs/node/pull/42629
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add NodeEdKeyGenParams to CryptoKey.algorithm #42629

Merged
merged 1 commit into from Apr 13, 2022
Merged

doc: add NodeEdKeyGenParams to CryptoKey.algorithm #42629

merged 1 commit into from Apr 13, 2022

Conversation

tniessen
Copy link
Member

@tniessen tniessen commented Apr 6, 2022

Example of a CryptoKey whose algorithm is a NodeEdKeyGenParams object:

const { publicKey } = await crypto.webcrypto.subtle.generateKey({
  name: 'NODE-ED25519',
  namedCurve: 'NODE-ED25519'
}, true, ['sign']);
console.log(publicKey.algorithm);

@tniessen tniessen requested a review from panva Apr 6, 2022
@nodejs-github-bot nodejs-github-bot added crypto doc labels Apr 6, 2022
panva
panva approved these changes Apr 6, 2022
View changes
Copy link
Member

@panva panva left a comment

One more thing to rebase for in #42507 ;)

@tniessen
Copy link
Author

@tniessen tniessen commented Apr 6, 2022

@panva Ah sorry, I didn't compare with #42507 before opening this.

@tniessen tniessen added the author ready label Apr 6, 2022
@tniessen tniessen added the commit-queue label Apr 13, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue label Apr 13, 2022
@nodejs-github-bot nodejs-github-bot merged commit f825341 into nodejs:master Apr 13, 2022
22 checks passed
@nodejs-github-bot
Copy link

@nodejs-github-bot nodejs-github-bot commented Apr 13, 2022

Landed in f825341

vmoroz pushed a commit to vmoroz/node that referenced this issue Apr 13, 2022
@tniessen @vmoroz
doc: add NodeEdKeyGenParams to CryptoKey.algorithm
52ab23b 
PR-URL: nodejs#42629
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Apr 14, 2022
Merged
xtx1130 pushed a commit to xtx1130/node that referenced this issue Apr 25, 2022
@tniessen @xtx1130
doc: add NodeEdKeyGenParams to CryptoKey.algorithm
7b15545 
PR-URL: nodejs#42629
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panva panva

@jasnell jasnell

Assignees
No one assigned
Labels
author ready crypto doc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tniessen @nodejs-github-bot @panva @jasnell
X Tutup