os: avoid unnecessary usage of var #42563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `var` keyword is known to be problematic and is not needed here, so better to use the `let` keyword for variable declarations.
nodejs-github-bot
added
needs-ci
tniessen
approved these changes
Apr 1, 2022
I'm surprised to see we still have some var declarations (assuming there are no performance edge cases here, but I think V8 fixed those years ago).
benjamingr
approved these changes
Apr 1, 2022
|
Running the os benchmarks to be sure because we have a benchmark test for node/benchmark/os/networkInterfaces.js Line 13 in d484cba which we are touching in this PR and we still have comments like node/lib/internal/async_hooks.js Lines 197 to 198 in d484cba https://ci.nodejs.org/job/benchmark-node-micro-benchmarks/1115/ I guess, we can replace all the |
cjihrig
approved these changes
Apr 1, 2022
marsonya
approved these changes
Apr 1, 2022
lpinca
approved these changes
Apr 1, 2022
marsonya
added
author ready
Trott
approved these changes
Apr 2, 2022
github-actions
bot
removed
the
request-ci
RaisinTen
added
the
author ready
jasnell
approved these changes
Apr 3, 2022
|
A bit of an aside, but I've re-added the It's perhaps a bit confusingly named, but the |
Trott
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in b5f0b49 |
juanarbol
added a commit
to juanarbol/node
that referenced
this issue
Apr 5, 2022
The `var` keyword is known to be problematic and is not needed here, so better to use the `let` keyword for variable declarations. PR-URL: nodejs#42563 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Closed
Merged
juanarbol
added a commit
that referenced
this issue
Apr 6, 2022
The `var` keyword is known to be problematic and is not needed here, so better to use the `let` keyword for variable declarations. PR-URL: #42563 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The
varkeyword is known to be problematic and is not needed here,so better to use the
letkeyword for variable declarations.