doc: remove unneeded new in Buffer example #42682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
buffer
Mesteery
approved these changes
Apr 10, 2022
aduh95
approved these changes
Apr 10, 2022
VoltrexMaster
approved these changes
Apr 10, 2022
tniessen
approved these changes
Apr 10, 2022
Trott
approved these changes
Apr 10, 2022
Trott
added
fast-track
|
Fast-track has been requested by @Trott. Please |
Trott
added
fast-track
|
Fast-track has been requested by @Trott. Please |
RaisinTen
approved these changes
Apr 10, 2022
lpinca
approved these changes
Apr 10, 2022
marsonya
approved these changes
Apr 10, 2022
marsonya
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/42682 ✔ Done loading data for nodejs/node/pull/42682 ----------------------------------- PR info ------------------------------------ Title doc: remove unneeded new in Buffer example (#42682) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch mischnic:patch-1 -> nodejs:master Labels buffer, doc, fast-track, author ready Commits 1 - doc: remove unneeded new in Buffer example Committers 1 - GitHub PR-URL: https://github.com/nodejs/node/pull/42682 Reviewed-By: Mestery Reviewed-By: Antoine du Hamel Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Tobias Nießen Reviewed-By: Rich Trott Reviewed-By: Darshan Sen Reviewed-By: Luigi Pinca Reviewed-By: Akhil Marsonya ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/42682 Reviewed-By: Mestery Reviewed-By: Antoine du Hamel Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Tobias Nießen Reviewed-By: Rich Trott Reviewed-By: Darshan Sen Reviewed-By: Luigi Pinca Reviewed-By: Akhil Marsonya -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 10 Apr 2022 08:59:39 GMT ✔ Approvals: 8 ✔ - Mestery (@Mesteery): https://github.com/nodejs/node/pull/42682#pullrequestreview-937234073 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/42682#pullrequestreview-937252973 ✔ - Mohammed Keyvanzadeh (@VoltrexMaster): https://github.com/nodejs/node/pull/42682#pullrequestreview-937260732 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/42682#pullrequestreview-937263917 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/42682#pullrequestreview-937264955 ✔ - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/42682#pullrequestreview-937269586 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/42682#pullrequestreview-937313392 ✔ - Akhil Marsonya (@marsonya): https://github.com/nodejs/node/pull/42682#pullrequestreview-937314254 ℹ This PR is being fast-tracked ✖ The fast-track request requires at least one collaborator's approval (👍). ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/2144740639 |
aduh95
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 951dbc0 |
xtx1130
pushed a commit
to xtx1130/node
that referenced
this issue
Apr 25, 2022
PR-URL: nodejs#42682 Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
new Buffer.from([])does actually work, but it's not really the intended usage (and it's not consistent with the other examples)