X Tutup
The Wayback Machine - https://web.archive.org/web/20201221004801/https://github.com/nodejs/node-core-utils/issues/504
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support v8 revert #504

Open
gengjiawen opened this issue Oct 2, 2020 · 2 comments
Open

support v8 revert #504

gengjiawen opened this issue Oct 2, 2020 · 2 comments

Comments

@gengjiawen
Copy link
Member

@gengjiawen gengjiawen commented Oct 2, 2020

support revert v8 commit by hash, should be usefully when test V8 function. Like nodejs/node#35415 (comment), I have a guess, but cumbersome reverting the commit in node.js repo.

@joyeecheung
Copy link
Member

@joyeecheung joyeecheung commented Oct 20, 2020

Would be useful for nodejs/node-v8#175 too. We probably just need to add --reverse to the git apply command to make it work

@gengjiawen
Copy link
Member Author

@gengjiawen gengjiawen commented Oct 20, 2020

Also my guess for nodejs/node#35415 (comment) is right, though I manually revert them, take quite some time (The final fix is not revert though, I found a workaround).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.
X Tutup