X Tutup
The Wayback Machine - https://web.archive.org/web/20220405130520/https://github.com/nodejs/node-addon-api/pull/1090
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: document object iterators #1090

Merged
merged 1 commit into from Oct 25, 2021

Conversation

Copy link
Member

@RaisinTen RaisinTen commented Oct 10, 2021

Signed-off-by: Darshan Sen darshan.sen@postman.com

@RaisinTen
Copy link
Member Author

@RaisinTen RaisinTen commented Oct 10, 2021

cc @NickNaso I've followed the suggestions you've left in #930 (review) :)

Copy link
Member

@mhdawson mhdawson left a comment

LGTM

@mhdawson
Copy link
Member

@mhdawson mhdawson commented Oct 13, 2021

@RaisinTen thanks for creating this follow up PR.

Copy link
Member

@NickNaso NickNaso left a comment

Well done, just few notes.

doc/object.md Outdated Show resolved Hide resolved
doc/object.md Outdated Show resolved Hide resolved
doc/object.md Outdated Show resolved Hide resolved
doc/object.md Outdated Show resolved Hide resolved
Signed-off-by: Darshan Sen <darshan.sen@postman.com>
@RaisinTen RaisinTen force-pushed the doc/document-object-iterators branch from a4d851c to dfe39ee Compare Oct 15, 2021
@RaisinTen
Copy link
Member Author

@RaisinTen RaisinTen commented Oct 15, 2021

@NickNaso thanks, updated accordingly :)

@RaisinTen RaisinTen requested a review from NickNaso Oct 15, 2021
Copy link
Member

@mhdawson mhdawson left a comment

LGTM

@mhdawson mhdawson merged commit 0dfa89f into nodejs:main Oct 25, 2021
23 checks passed
@RaisinTen RaisinTen deleted the doc/document-object-iterators branch Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants
X Tutup