Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Automatically create sort groups based on newlines in organize imports #48330
+141
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
typescript-bot
added
the
For Uncommitted Bug
MQuy
force-pushed
the
feature/create-sort-groups-by-newlines
branch
from
ff8df38
to
b89f697
Compare
typescript-bot
added
For Backlog Bug
jakebailey
requested changes
Mar 28, 2022
This looks about right to me, but I think what I'd like to see are a few more tests to cover cases where there are comments, e.g., what is the behavior when we have something like:
// polyfill
import "lib"
// not polyfill
import { b } from "lib2"or say
import "lib" // xyz
import c from "C"Or similar (this isn't exhaustive). I know the original issue had some code snippets that feature comments.
jakebailey
reviewed
Mar 28, 2022
jakebailey
reviewed
Mar 28, 2022
MQuy
force-pushed
the
feature/create-sort-groups-by-newlines
branch
from
fd96817
to
2c13fec
Compare
jakebailey
reviewed
Mar 30, 2022
jakebailey
reviewed
Apr 5, 2022
MQuy
force-pushed
the
feature/create-sort-groups-by-newlines
branch
from
aa759f0
to
24e4cd9
Compare
MQuy
force-pushed
the
feature/create-sort-groups-by-newlines
branch
from
f594067
to
bd8ce22
Compare
jakebailey
reviewed
Apr 5, 2022
Co-authored-by: Jake Bailey <5341706+jakebailey@users.noreply.github.com>
jakebailey
reviewed
Apr 5, 2022
jakebailey
approved these changes
Apr 5, 2022
DanielRosenwasser
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Closes #41494.
Based on @RyanCavanaugh's suggestion #41494 (comment)
when organizing imports in each block of newline-contiguous
turns into