X Tutup
The Wayback Machine - https://web.archive.org/web/20220111020206/https://github.com/TheAlgorithms/Java/pull/2860
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature quick select #2860

Merged
merged 3 commits into from Dec 8, 2021
Merged

Conversation

@Nils-Goldmann
Copy link
Contributor

@Nils-Goldmann Nils-Goldmann commented Dec 5, 2021

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

References

Wikipedia Entry

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
@Nils-Goldmann
Copy link
Contributor Author

@Nils-Goldmann Nils-Goldmann commented Dec 6, 2021

There are two automatic checks that failed: Build and Prettify.

Build uses javac as a compiler in build.yml, while my colleague and I compiled using Maven. I am pretty sure that this is the reason for the failure. How should we proceed on this? We could change build.yml accordingly, if this is an option for you.

Also, Prettify failed and it is not quite obvious to me why. Do you maybe have an idea what the reason could be?

@siriak
Copy link
Member

@siriak siriak commented Dec 7, 2021

The prettier is just faulty, nvm

@siriak
Copy link
Member

@siriak siriak commented Dec 7, 2021

I've changed builds to maven, the verify command used should run your tests, right?

@Nils-Goldmann
Copy link
Contributor Author

@Nils-Goldmann Nils-Goldmann commented Dec 7, 2021

I've changed builds to maven, the verify command used should run your tests, right?

During our work, we used the test command, but verify also seems to work.

siriak
siriak approved these changes Dec 8, 2021
Copy link
Member

@siriak siriak left a comment

LGTM, thanks!

@siriak siriak merged commit 66d8d51 into TheAlgorithms:master Dec 8, 2021
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
X Tutup