X Tutup
The Wayback Machine - https://web.archive.org/web/20260129122800/https://github.com/python/cpython/pull/31899
Skip to content

gh-90449: Improve accuracy and readability of exceptions tutorial #31899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iritkatriel merged 8 commits into from
Apr 13, 2022
Merged

gh-90449: Improve accuracy and readability of exceptions tutorial #31899

iritkatriel merged 8 commits into from
Apr 13, 2022

Conversation

@iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Mar 15, 2022 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot added the docs Documentation in the Doc dir label Mar 15, 2022
@iritkatriel iritkatriel requested a review from ncoghlan March 15, 2022 11:41
iritkatriel
iritkatriel commented Mar 15, 2022
View reviewed changes
@iritkatriel iritkatriel requested a review from merwok March 22, 2022 12:29
merwok
merwok reviewed Mar 22, 2022
View reviewed changes
merwok
merwok requested changes Mar 23, 2022
View reviewed changes
Copy link
Member

@merwok merwok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is shaping up nicely!

@bedevere-bot
Copy link

bedevere-bot commented Mar 23, 2022

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

iritkatriel
iritkatriel commented Mar 23, 2022
View reviewed changes
iritkatriel
iritkatriel commented Mar 23, 2022
View reviewed changes
@iritkatriel @merwok
Apply suggestions from code review
2589839 
Co-authored-by: Éric <merwok@netwok.org>
iritkatriel
iritkatriel commented Mar 23, 2022
View reviewed changes
@iritkatriel
Copy link
Member Author

iritkatriel commented Mar 23, 2022

Apart from this one:
https://github.com/python/cpython/pull/31899/files#r833668489

I have made the requested changes; please review again.

@bedevere-bot
Copy link

bedevere-bot commented Mar 23, 2022

Thanks for making the requested changes!

@merwok: please review the changes made to this pull request.

@bedevere-bot bedevere-bot requested a review from merwok March 23, 2022 20:03
merwok
merwok reviewed Mar 24, 2022
View reviewed changes
JelleZijlstra
JelleZijlstra reviewed Mar 26, 2022
View reviewed changes
@iritkatriel
Copy link
Member Author

iritkatriel commented Apr 13, 2022

I have made the requested changes; please review again.

@bedevere-bot
Copy link

bedevere-bot commented Apr 13, 2022

Thanks for making the requested changes!

@merwok: please review the changes made to this pull request.

@bedevere-bot bedevere-bot requested a review from merwok April 13, 2022 10:51
@JelleZijlstra JelleZijlstra self-requested a review April 13, 2022 14:48
JelleZijlstra
JelleZijlstra approved these changes Apr 13, 2022
View reviewed changes
Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is very readable

@iritkatriel iritkatriel changed the title bpo-46291: Fix inaccuracies in exceptions tutorial gh-90449: Fix inaccuracies in exceptions tutorial Apr 13, 2022
@iritkatriel iritkatriel merged commit 04f9658 into python:main Apr 13, 2022
@iritkatriel iritkatriel changed the title gh-90449: Fix inaccuracies in exceptions tutorial gh-90449: Improve accuracy and readability of exceptions tutorial Apr 13, 2022
@gtitze gtitze mannequin mentioned this pull request Apr 10, 2022
Closed
@iritkatriel iritkatriel deleted the bpo-46291 branch May 20, 2022 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@ncoghlan ncoghlan Awaiting requested review from ncoghlan

@merwok merwok Awaiting requested review from merwok

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@iritkatriel @bedevere-bot @merwok @JelleZijlstra @the-knights-who-say-ni
X Tutup