net,dns: trace tcp connection and dns by perf_hooks #42390
Merged
+272
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested: |
nodejs-github-bot
added
lib / src
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
theanarkh
force-pushed
the
trace_net_and_dns_by_perf_hooks
branch
2 times, most recently
from
3508c15
to
d63fe2b
Compare
theanarkh
force-pushed
the
trace_net_and_dns_by_perf_hooks
branch
from
d63fe2b
to
edff14f
Compare
VoltrexMaster
reviewed
Mar 18, 2022
theanarkh
force-pushed
the
trace_net_and_dns_by_perf_hooks
branch
2 times, most recently
from
ec85f61
to
c7213e4
Compare
37 tasks
This comment was marked as outdated.
This comment was marked as outdated.
theanarkh
force-pushed
the
trace_net_and_dns_by_perf_hooks
branch
from
c7213e4
to
98d4677
Compare
VoltrexMaster
approved these changes
Mar 19, 2022
VoltrexMaster
added
author ready
36 tasks
37 tasks
theanarkh
force-pushed
the
trace_net_and_dns_by_perf_hooks
branch
from
98d4677
to
9d395b7
Compare
32 tasks
use the perf_hooks to trace the time spent by net.connect, dns.lookup, dns.lookupService, dns.resolvexxx.
theanarkh
force-pushed
the
trace_net_and_dns_by_perf_hooks
branch
from
9d395b7
to
62b33bb
Compare
|
Is this PR ok or is there anything I need to do？ |
|
@mcollina hello, Is this PR ok or is there anything I need to do？thanks. |
mcollina
added
the
commit-queue
|
This can land! |
nodejs-github-bot
removed
the
commit-queue
Commit Queue failed- Loading data for nodejs/node/pull/42390 ✔ Done loading data for nodejs/node/pull/42390 ----------------------------------- PR info ------------------------------------ Title net,dns: trace tcp connection and dns by perf_hooks (#42390) Author theanarkh (@theanarkh, first-time contributor) Branch theanarkh:trace_net_and_dns_by_perf_hooks -> nodejs:master Labels lib / src, author ready Commits 1 - net,dns: trace tcp connection and dns by perf_hooks Committers 1 - theanarkh <2923878201@qq.com> PR-URL: https://github.com/nodejs/node/pull/42390 Reviewed-By: Matteo Collina Reviewed-By: Paolo Insogna Reviewed-By: Mohammed Keyvanzadeh ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/42390 Reviewed-By: Matteo Collina Reviewed-By: Paolo Insogna Reviewed-By: Mohammed Keyvanzadeh -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - net,dns: trace tcp connection and dns by perf_hooks ℹ This PR was created on Fri, 18 Mar 2022 13:13:33 GMT ✔ Approvals: 3 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/42390#pullrequestreview-914468480 ✔ - Paolo Insogna (@ShogunPanda): https://github.com/nodejs/node/pull/42390#pullrequestreview-914493022 ✔ - Mohammed Keyvanzadeh (@VoltrexMaster): https://github.com/nodejs/node/pull/42390#pullrequestreview-915032295 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2022-03-24T09:18:30Z: https://ci.nodejs.org/job/node-test-pull-request/43182/ - Querying data for job/node-test-pull-request/43182/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/2059520015 |
nodejs-github-bot
added
the
commit-queue-failed
mcollina
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in e520039 |
juanarbol
pushed a commit
that referenced
this issue
Apr 4, 2022
use the perf_hooks to trace the time spent by net.connect, dns.lookup, dns.lookupService, dns.resolvexxx. PR-URL: #42390 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
juanarbol
pushed a commit
to juanarbol/node
that referenced
this issue
Apr 5, 2022
use the perf_hooks to trace the time spent by net.connect, dns.lookup, dns.lookupService, dns.resolvexxx. PR-URL: nodejs#42390 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Closed
Merged
juanarbol
pushed a commit
that referenced
this issue
Apr 6, 2022
use the perf_hooks to trace the time spent by net.connect, dns.lookup, dns.lookupService, dns.resolvexxx. PR-URL: #42390 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
xtx1130
pushed a commit
to xtx1130/node
that referenced
this issue
Apr 25, 2022
use the perf_hooks to trace the time spent by net.connect, dns.lookup, dns.lookupService, dns.resolvexxx. PR-URL: nodejs#42390 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
use the perf_hooks to trace the time spent by net.connect, dns.lookup,
dns.lookupService, dns.resolvexxx.
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s): net, dns