X Tutup
The Wayback Machine - https://web.archive.org/web/20220502045140/https://github.com/nodejs/node/pull/42378
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: improve README.md usability #42378

Merged
merged 1 commit into from Mar 19, 2022
Merged

doc: improve README.md usability #42378

merged 1 commit into from Mar 19, 2022

Conversation

Copy link
Member

@Trott Trott commented Mar 17, 2022

  • The logo takes a lot of room doesn't add information.
  • Make Node.js a top-level header and Table of Contents a second-level
    header.

This looks better, improve semantics, makes the README.md more usable in
its raw form, and aligns us with README.md practices in other projects
like TypeScript and Deno.

@nodejs-github-bot nodejs-github-bot added the doc label Mar 17, 2022
@Trott
Copy link
Author

@Trott Trott commented Mar 17, 2022

Before in dark mode:

image

After in dark mode:

image

@Trott
Copy link
Author

@Trott Trott commented Mar 17, 2022

Before in light mode:

image

After in light mode:

image

* The logo takes a lot of room doesn't add information.
* Make Node.js a top-level header and Table of Contents a  second-level
  header.

This looks better, improve semantics, makes the README.md more usable in
its raw form, and aligns us with README.md practices in other projects
like TypeScript and Deno.
@Trott
Copy link
Author

@Trott Trott commented Mar 17, 2022

Current raw display:

image

Raw display with this PR:

image

@Trott Trott added the author ready label Mar 17, 2022
@Trott Trott added the commit-queue label Mar 19, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue label Mar 19, 2022
@nodejs-github-bot nodejs-github-bot merged commit 7fdb9d5 into nodejs:master Mar 19, 2022
15 checks passed
@nodejs-github-bot
Copy link

@nodejs-github-bot nodejs-github-bot commented Mar 19, 2022

Landed in 7fdb9d5

@Trott Trott deleted the no-logo branch Mar 19, 2022
bengl pushed a commit that referenced this issue Mar 21, 2022
* The logo takes a lot of room doesn't add information.
* Make Node.js a top-level header and Table of Contents a  second-level
  header.

This looks better, improve semantics, makes the README.md more usable in
its raw form, and aligns us with README.md practices in other projects
like TypeScript and Deno.

PR-URL: #42378
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
@bengl bengl mentioned this pull request Mar 21, 2022
danielleadams pushed a commit to danielleadams/node that referenced this issue Apr 21, 2022
* The logo takes a lot of room doesn't add information.
* Make Node.js a top-level header and Table of Contents a  second-level
  header.

This looks better, improve semantics, makes the README.md more usable in
its raw form, and aligns us with README.md practices in other projects
like TypeScript and Deno.

PR-URL: nodejs#42378
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
danielleadams pushed a commit that referenced this issue Apr 24, 2022
* The logo takes a lot of room doesn't add information.
* Make Node.js a top-level header and Table of Contents a  second-level
  header.

This looks better, improve semantics, makes the README.md more usable in
its raw form, and aligns us with README.md practices in other projects
like TypeScript and Deno.

PR-URL: #42378
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
danielleadams pushed a commit that referenced this issue Apr 24, 2022
* The logo takes a lot of room doesn't add information.
* Make Node.js a top-level header and Table of Contents a  second-level
  header.

This looks better, improve semantics, makes the README.md more usable in
its raw form, and aligns us with README.md practices in other projects
like TypeScript and Deno.

PR-URL: #42378
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
danielleadams pushed a commit that referenced this issue Apr 24, 2022
* The logo takes a lot of room doesn't add information.
* Make Node.js a top-level header and Table of Contents a  second-level
  header.

This looks better, improve semantics, makes the README.md more usable in
its raw form, and aligns us with README.md practices in other projects
like TypeScript and Deno.

PR-URL: #42378
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
xtx1130 pushed a commit to xtx1130/node that referenced this issue Apr 25, 2022
* The logo takes a lot of room doesn't add information.
* Make Node.js a top-level header and Table of Contents a  second-level
  header.

This looks better, improve semantics, makes the README.md more usable in
its raw form, and aligns us with README.md practices in other projects
like TypeScript and Deno.

PR-URL: nodejs#42378
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready doc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants
X Tutup