X Tutup
The Wayback Machine - https://web.archive.org/web/20220502045131/https://github.com/nodejs/node/pull/42370
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add that chacha20-poly1305 is IETF version #42370

Conversation

Copy link
Member

@tniessen tniessen commented Mar 16, 2022

Probably not the best place to document this, but it's a start that doesn't require too much repetition.

Refs: #42323 (comment)

@nodejs-github-bot nodejs-github-bot added crypto doc labels Mar 16, 2022
@tniessen tniessen force-pushed the doc-crypto-chacha20poly1305-ietf-in-changes branch from dffb056 to c78fa49 Compare Mar 17, 2022
@tniessen tniessen added the author ready label Mar 18, 2022
Copy link
Member

@mhdawson mhdawson left a comment

LGTM

@tniessen tniessen added the commit-queue label Mar 18, 2022
@nodejs-github-bot nodejs-github-bot added commit-queue-failed and removed commit-queue labels Mar 18, 2022
@nodejs-github-bot
Copy link

@nodejs-github-bot nodejs-github-bot commented Mar 18, 2022

Commit Queue failed
- Loading data for nodejs/node/pull/42370
FetchError: Invalid response body while trying to fetch https://api.github.com/graphql: Premature close
    at consumeBody (file:///opt/hostedtoolcache/node/16.14.0/x64/lib/node_modules/node-core-utils/node_modules/node-fetch/src/body.js:234:60)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at async Response.text (file:///opt/hostedtoolcache/node/16.14.0/x64/lib/node_modules/node-core-utils/node_modules/node-fetch/src/body.js:158:18)
    at async Request.json (file:///opt/hostedtoolcache/node/16.14.0/x64/lib/node_modules/node-core-utils/lib/request.js:49:18)
    at async Request.query (file:///opt/hostedtoolcache/node/16.14.0/x64/lib/node_modules/node-core-utils/lib/request.js:107:20)
    at async Request.queryAll (file:///opt/hostedtoolcache/node/16.14.0/x64/lib/node_modules/node-core-utils/lib/request.js:134:20)
    at async Request.gql (file:///opt/hostedtoolcache/node/16.14.0/x64/lib/node_modules/node-core-utils/lib/request.js:64:22)
    at async PRData.getComments (file:///opt/hostedtoolcache/node/16.14.0/x64/lib/node_modules/node-core-utils/lib/pr_data.js:97:21)
    at async Promise.all (index 2)
    at async Promise.all (index 1) {
  type: 'system',
  errno: 'ERR_STREAM_PREMATURE_CLOSE',
  code: 'ERR_STREAM_PREMATURE_CLOSE',
  erroredSysCall: undefined
}
https://github.com/nodejs/node/actions/runs/2006803970

@tniessen tniessen added commit-queue and removed commit-queue-failed labels Mar 18, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue label Mar 19, 2022
@nodejs-github-bot nodejs-github-bot merged commit fff95ae into nodejs:master Mar 19, 2022
22 checks passed
@nodejs-github-bot
Copy link

@nodejs-github-bot nodejs-github-bot commented Mar 19, 2022

Landed in fff95ae

bengl pushed a commit that referenced this issue Mar 21, 2022
PR-URL: #42370
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
@bengl bengl mentioned this pull request Mar 21, 2022
danielleadams pushed a commit that referenced this issue Apr 21, 2022
PR-URL: #42370
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
danielleadams pushed a commit that referenced this issue Apr 24, 2022
PR-URL: #42370
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
danielleadams pushed a commit that referenced this issue Apr 24, 2022
PR-URL: #42370
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
danielleadams pushed a commit that referenced this issue Apr 24, 2022
PR-URL: #42370
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
xtx1130 pushed a commit to xtx1130/node that referenced this issue Apr 25, 2022
PR-URL: nodejs#42370
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready crypto doc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants
X Tutup