tools: support versioned node shared libraries on z/OS #42256
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
build
|
@alexcfyung I assume this should not land until - nodejs/gyp-next#137 does. |
mhdawson
reviewed
Mar 10, 2022
tools/install.py
Outdated
| @@ -142,8 +157,29 @@ def files(action): | |||
| else: | |||
| output_file = 'lib' + output_file + '.' + variables.get('shlib_suffix') | |||
|
|
|||
| # GYP will output to lib.target except on OS X, this is hardcoded | |||
There was a problem hiding this comment.
I don't understand the OS X comment here for a section that is zos specific?
There was a problem hiding this comment.
I think this comment was left in by mistake. I have went ahead and removed it.
jasnell
approved these changes
Mar 10, 2022
|
@alexcfyung it looks like the two referenced PRs have landed. |
|
@alexcfyung can you rebase and then I'll kick off the CI and work to get it landed. |
This comment was marked as spam.
This comment was marked as spam.
The shared libraries will now be stores in lib.target as opposed to obj.target, libnode.version.so, libnode.x (for npm backwards compat and testing), and libnode.version.x (for builds). The install will also include libnode.so link that points to libnode.version.so (this will be used by native npms for backwards compat). Co-authored-by: Gaby Baghdadi <baghdadi@ca.ibm.com> Co-authored-by: Wayne Zhang <shuowang.zhang@ibm.com>
|
@mhdawson Alex is no longer working with z/OS. I went ahead and rebased this PR as requested. |
|
@zsw007 thanks! |
github-actions
bot
removed
the
request-ci
24 tasks
19 tasks
16 tasks
16 tasks
|
Landed in ed7b676 |
mhdawson
pushed a commit
that referenced
this issue
Jul 21, 2022
The shared libraries will now be stores in lib.target as opposed to obj.target, libnode.version.so, libnode.x (for npm backwards compat and testing), and libnode.version.x (for builds). The install will also include libnode.so link that points to libnode.version.so (this will be used by native npms for backwards compat). PR-URL: #42256 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Co-authored-by: Gaby Baghdadi <baghdadi@ca.ibm.com> Co-authored-by: Wayne Zhang <shuowang.zhang@ibm.com>
15 tasks
15 tasks
17 tasks
16 tasks
danielleadams
pushed a commit
that referenced
this issue
Jul 26, 2022
The shared libraries will now be stores in lib.target as opposed to obj.target, libnode.version.so, libnode.x (for npm backwards compat and testing), and libnode.version.x (for builds). The install will also include libnode.so link that points to libnode.version.so (this will be used by native npms for backwards compat). PR-URL: #42256 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Co-authored-by: Gaby Baghdadi <baghdadi@ca.ibm.com> Co-authored-by: Wayne Zhang <shuowang.zhang@ibm.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The shared libraries will now be stores in lib.target as opposed to
obj.target, libnode.version.so, libnode.x (for npm backwards compat and
testing), and libnode.version.x (for builds). The install will also
include libnode.so link that points to libnode.version.so (this will be
used by native npms for backwards compat).
This PR is depend on nodejs/node-gyp#2619 and nodejs/gyp-next#137.