util: make debuglog show up in --inspect logs #41884
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmeck
added
util
|
Review requested: |
joyeecheung
reviewed
Feb 7, 2022
Removing the TODO LGTM (it already doesn't matter now that we snapshot the console methods) , but I have a question regarding the implementation of the wrapping
jasnell
approved these changes
Feb 12, 2022
bmeck
added
the
semver-major
addaleax
approved these changes
Mar 8, 2022
addaleax
requested changes
Mar 8, 2022
|
@addaleax I've pulled out the console changes for now. Would it be fine to have these as a separate PR still? |
addaleax
approved these changes
Mar 8, 2022
Would it be fine to have these as a separate PR still?
I think so -- it's definitely a breaking change, though. (This PR doesn't need to be semver-major anymore imo.)
bmeck
removed
the
semver-major
15 tasks
37 tasks
36 tasks
37 tasks
32 tasks
joyeecheung
approved these changes
Mar 22, 2022
28 tasks
29 tasks
27 tasks
26 tasks
26 tasks
24 tasks
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This makes
util.debuglog()show up in the inspector console under thedebuglevel.@joyeecheung I've removed the TODO comment since it loses data prior to connection of an inspector which is a UX degradation from the existing situation and doesn't match other environments for JS.
This does cause the same kind of memory leak while retaining messages as
consolecurrently does but it only does so if the specificdebuglogset is enabled.