async_hooks: prototype for v8 reimplementation of AsyncLocalStorage #42393
Conversation
Qard
added
v8 engine
|
Review requested:
|
nodejs-github-bot
added
lib / src
Qard
force-pushed
the
v8-context-storage
branch
from
e0323df to
1c0f44a
Compare
Do you have an estimate of how much of a performance gain this has? |
|
Not yet. Still just focused on making it work. I'll do measurements later. |
|
Had some discussions with V8 folks and they're not keen on moving this much of the API into V8. However, there are some new things in V8 that should help to accommodate this need with a bit of alterations. Certainly https://chromium-review.googlesource.com/c/v8/v8/+/2005849 should be helpful. I'll work on this some more soon. :) |
|
Pretty sure I'll be able to find a bit more time for this soon. Just challenging with some big projects on my plate getting wrapped up soon and currently being a one person team. My team is hiring if you're looking for piles of stuff to do. 😅 |
Reimplementation of AsyncLocalStorage to bypass async_hooks.
|
Did a bit of restructuring recently to move away from V8 changes. Still more work to do and needs some refactoring to work better when I add support for promises and timers. |
|
Closing as I haven't had the time for this and it sounds like there's some other similar efforts incoming. 😅 |
3 participants
This is an experiment in moving the machinery necessary for
AsyncLocalStorageaway fromasync_hooksand into V8 itself. The purpose is for better performance by entirely eliminating the unnecessary event sequence component ofasync_hooksand to enable sharing storage state with V8. This is very much a proof-of-concept in its current state. It's failing a bunch of tests still, that's expected, it's not complete yet.Feel free to have a look and provide feedback on the direction if you like, just keep in mind this is not done yet.