X Tutup
The Wayback Machine - https://web.archive.org/web/20220321150000/https://github.com/angular/angular/pull/41434
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update several dependencies #41434

Closed
wants to merge 15 commits into from

Conversation

alan-agius4
Copy link
Contributor

@alan-agius4 alan-agius4 commented Apr 3, 2021

test: remove cli-hello-world-lazy-rollup tests

In version 12 of the Angular CLI the experimentalRollupPass has been removed.

build: update Angular CLI packages to 12.0.0-next.7

With this change we update Angular CLI packages that are used in the repo for testing to 12.0.0-next.7

test(ngcc): provide correct source-mappings for renderer tests

The recent update to MagicString, results in a different basic set of mappings in the renderer. This change updates our tests to match.

build(docs-infra): update dgeni-packages dependency

This update includes fixes that prevented us from updating
other dependencies.

ci: improve renovate configuration

With this change we add several packages to ignored ignoreDeps as these packages cannot be updated safely as they cause a large number of errors.

In addition, we add a group for remark packages.

build: update several dependencies

With this change we update several dependencies to avoid Renovate from create a lot of PRs during onboarding. We also remove yarn workspaces as after further analysis these are not needed.

Certain dependencies such as @octokit/rest, remark and @babel/* have not been updated as they require a decent amount of work to update, and it's best to leave them for a seperate PR.

@google-cla google-cla bot added the cla: yes label Apr 3, 2021
@alan-agius4 alan-agius4 force-pushed the packages-update branch 10 times, most recently from 022889a to 4f60e01 Compare Apr 3, 2021
@gkalpak gkalpak self-requested a review Apr 3, 2021
@alan-agius4 alan-agius4 force-pushed the packages-update branch 16 times, most recently from c02c551 to 9c49b9b Compare Apr 5, 2021
alan-agius4 added 4 commits Apr 12, 2021
This is a temporary workaround until the CLI version containing a fix for the regression caused by deacc74 is available on NPM.

Without this change CLI builds will fail with;
```
angularCompiler.getNextProgram is not a function
```
@alan-agius4 alan-agius4 force-pushed the packages-update branch 2 times, most recently from 689bfb9 to 029799a Compare Apr 12, 2021
In Angular CLI 12, application can only be compiled using Ivy, therefore we shouldn't run these tests when Bazel runs with View Engine context.
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Reviewed-for: size-tracking

zarend added a commit that referenced this issue Apr 12, 2021
With this change we add several packages to ignored `ignoreDeps` as these packages cannot be updated safely as they cause a large number of errors.

In addition, we add a group for `remark` packages.

PR Close #41434
zarend added a commit that referenced this issue Apr 12, 2021
This update includes fixes that prevented us from updating
other dependencies.

PR Close #41434
zarend added a commit that referenced this issue Apr 12, 2021
The recent update to MagicString, results in a different basic set of
mappings in the renderer. This change updates our tests to match.

PR Close #41434
zarend added a commit that referenced this issue Apr 12, 2021
With this change we update Angular CLI packages that are used in the repo for testing to `12.0.0-next.7`

PR Close #41434
zarend added a commit that referenced this issue Apr 12, 2021
In version 12 of the Angular CLI the `experimentalRollupPass` has been removed.

PR Close #41434
zarend added a commit that referenced this issue Apr 12, 2021
This is a temporary workaround until the CLI version containing a fix for the regression caused by deacc74 is available on NPM.

Without this change CLI builds will fail with;
```
angularCompiler.getNextProgram is not a function
```

PR Close #41434
zarend added a commit that referenced this issue Apr 12, 2021
In Angular CLI 12, application can only be compiled using Ivy, therefore we shouldn't run these tests when Bazel runs with View Engine context.

PR Close #41434
@alan-agius4 alan-agius4 deleted the packages-update branch Apr 13, 2021
@angular-automatic-lock-bot
Copy link

@angular-automatic-lock-bot angular-automatic-lock-bot bot commented May 14, 2021

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

9 participants
X Tutup