X Tutup
The Wayback Machine - https://web.archive.org/web/20220320003339/https://github.com/python/cpython/pull/31893
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing newline to NEWS entry #31893

Merged
merged 1 commit into from Mar 15, 2022
Merged

Add missing newline to NEWS entry #31893

merged 1 commit into from Mar 15, 2022

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Mar 15, 2022

Follow on from #31046.

After merge, the CI complained about a missing newline:

Starting: Build documentation
==============================================================================
Task         : Command line
Description  : Run a command line script using Bash on Linux and macOS and cmd.exe on Windows
Version      : 2.200.2
Author       : Microsoft Corporation
Help         : https://docs.microsoft.com/azure/devops/pipelines/tasks/utility/command-line
==============================================================================
Generating script.
Script contents:
make check html PYTHON=python
========================== Starting Command Output ===========================
/usr/bin/bash --noprofile --norc /home/vsts/work/_temp/87ee4e78-ecff-4ef4-908d-8f9026f9e23a.sh
PATH=./venv/bin:$PATH sphinx-lint -i tools -i ./venv -i README.rst
No problems found.
PATH=./venv/bin:$PATH sphinx-lint ../Misc/NEWS.d/next/
[1] ../Misc/NEWS.d/next/Core and Builtins/2022-02-01-10-05-27.[bpo-43721](https://bugs.python.org/issue43721).-1XAIo.rst:0: No newline at end of file (no-newline-at-end-of-file).
1 problem with severity 1 found.
make: *** [Makefile:219: check] Error 1
##[error]Bash exited with code '2'.
Finishing: Build documentation

https://dev.azure.com/Python/cpython/_build/results?buildId=98584&view=logs&j=4db1505a-29e5-5cc0-240b-53a8a2681f75&t=a975920c-8356-5388-147c-613d5fab0171

(To run locally: make -C Doc check html PYTHON=python)

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Mar 15, 2022

Thanks @hugovk for the PR, and @iritkatriel for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒🤖

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Mar 15, 2022

Thanks @hugovk for the PR, and @iritkatriel for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒🤖

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Mar 15, 2022

GH-31894 is a backport of this pull request to the 3.9 branch.

miss-islington added a commit to miss-islington/cpython that referenced this issue Mar 15, 2022
(cherry picked from commit 16995ed)

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Mar 15, 2022

GH-31896 is a backport of this pull request to the 3.10 branch.

miss-islington added a commit to miss-islington/cpython that referenced this issue Mar 15, 2022
(cherry picked from commit 16995ed)

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
miss-islington added a commit that referenced this issue Mar 15, 2022
(cherry picked from commit 16995ed)

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
miss-islington added a commit that referenced this issue Mar 15, 2022
(cherry picked from commit 16995ed)

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
@hugovk hugovk deleted the fix-docs-ci branch Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
X Tutup