X Tutup
The Wayback Machine - https://web.archive.org/web/20260308023159/https://github.com/github/codeql/pull/8035
Skip to content

C#: Downgrade hardcoded credentials queries to medium precision#8035

Merged
yo-h merged 3 commits intogithub:mainfrom
tamasvajk:feature/hardcoded-cred-medium-prec
Feb 15, 2022
Merged

C#: Downgrade hardcoded credentials queries to medium precision#8035
yo-h merged 3 commits intogithub:mainfrom
tamasvajk:feature/hardcoded-cred-medium-prec

Conversation

@tamasvajk
Copy link
Contributor

No description provided.

@tamasvajk tamasvajk requested a review from a team as a code owner February 15, 2022 08:34
@tamasvajk tamasvajk requested a review from yo-h February 15, 2022 08:35
@github-actions github-actions bot added the C# label Feb 15, 2022
Copy link
Contributor

@michaelnebel michaelnebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Has there been identified false positives?

@tamasvajk
Copy link
Contributor Author

LGTM! Has there been identified false positives?

I don't know what prompted these changes, but we're downgrading these checks for all languages (see the linked issue).

@yo-h yo-h merged commit cfcb06c into github:main Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

X Tutup