X Tutup
The Wayback Machine - https://web.archive.org/web/20220321201602/https://github.com/nodejs/node/pull/41865
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add missing commas in cluster docs #41865

Merged
merged 1 commit into from Feb 5, 2022

Conversation

tniessen
Copy link
Member

@tniessen tniessen commented Feb 5, 2022

No description provided.

lpinca
lpinca approved these changes Feb 5, 2022
@github-actions
Copy link

@github-actions github-actions bot commented Feb 5, 2022

Fast-track has been requested by @lpinca. Please 👍 to approve.

Trott
Trott approved these changes Feb 5, 2022
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@DerekNonGeneric
Copy link
Contributor

@DerekNonGeneric DerekNonGeneric commented Feb 5, 2022

@Trott, for doc-only changes, it seems a bit of a waste to be running the whole barrage of tests.

Not only does it waste time, but it also unnecessarily wastes electricity and may contribute to climate change.

Can we set up something to detect which type of tests we toggle based on the change reflected by the labels added?

@Trott
Copy link
Member

@Trott Trott commented Feb 5, 2022

@Trott, for doc-only changes, it seems a bit of a waste to be running the whole barrage of tests.

Not only does it waste time, but it also unnecessarily wastes electricity and may contribute to climate change.

Can we set up something to detect which type of tests we toggle based on the change reflected by the labels added?

We (usually) don't run Jenkins for doc changes, so we're already running only a fraction of what we do for code changes. We have logic in some of our GitHub Actions workflows to skip in some cases. Efforts to make that more robust would be welcome.

@nodejs-github-bot nodejs-github-bot merged commit b8d994a into nodejs:master Feb 5, 2022
27 checks passed
@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Feb 5, 2022

Landed in b8d994a

ruyadorno added a commit that referenced this issue Feb 8, 2022
PR-URL: #41865
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
danielleadams added a commit that referenced this issue Mar 2, 2022
PR-URL: #41865
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
danielleadams added a commit that referenced this issue Mar 3, 2022
PR-URL: #41865
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
danielleadams added a commit to danielleadams/node that referenced this issue Mar 4, 2022
PR-URL: nodejs#41865
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
danielleadams added a commit to danielleadams/node that referenced this issue Mar 4, 2022
PR-URL: nodejs#41865
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
danielleadams added a commit that referenced this issue Mar 8, 2022
PR-URL: #41865
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
danielleadams added a commit that referenced this issue Mar 14, 2022
PR-URL: #41865
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
X Tutup