lib: remove erroneous JSDoc entry #41604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we should also move the description of the constructor to the JSDoc entry on top of |
Mesteery
approved these changes
Jan 20, 2022
I'll do that if you or others feel strongly about it. It seems more intuitive to me to have the description of the class where it is now. The examples at https://jsdoc.app/howto-es2015-classes.html do it that way too. |
VoltrexMaster
approved these changes
Jan 20, 2022
This comment has been hidden.
This comment has been hidden.
Commit Queue failed- Loading data for nodejs/node/pull/41604 ✔ Done loading data for nodejs/node/pull/41604 ----------------------------------- PR info ------------------------------------ Title lib: remove erroneous JSDoc entry (#41604) Author Rich Trott (@Trott) Branch Trott:jsdoc-class -> nodejs:master Labels author ready, needs-ci Commits 1 - lib: remove erroneous JSDoc entry Committers 1 - Rich Trott PR-URL: https://github.com/nodejs/node/pull/41604 Reviewed-By: Mestery Reviewed-By: Mohammed Keyvanzadeh ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/41604 Reviewed-By: Mestery Reviewed-By: Mohammed Keyvanzadeh -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 19 Jan 2022 22:12:37 GMT ✔ Approvals: 2 ✔ - Mestery (@Mesteery): https://github.com/nodejs/node/pull/41604#pullrequestreview-857763183 ✔ - Mohammed Keyvanzadeh (@VoltrexMaster): https://github.com/nodejs/node/pull/41604#pullrequestreview-858607620 ✖ GitHub CI is still running ℹ Last Full PR CI on 2022-01-21T17:29:57Z: https://ci.nodejs.org/job/node-test-pull-request/42071/ - Querying data for job/node-test-pull-request/42071/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1731079247 |
The entry contains incorrect parameters and duplicates the subsequent constructor entry. Remove it. (I'm not sure why this is being caught by the linter on my local machine but not in CI.) PR-URL: nodejs#41604 Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
|
Landed in 290911b |
17 tasks
13 tasks
22 tasks
28 tasks
BethGriggs
added a commit
that referenced
this issue
Jan 25, 2022
The entry contains incorrect parameters and duplicates the subsequent constructor entry. Remove it. (I'm not sure why this is being caught by the linter on my local machine but not in CI.) PR-URL: #41604 Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
26 tasks
Linkgoron
added a commit
to Linkgoron/node
that referenced
this issue
Jan 31, 2022
The entry contains incorrect parameters and duplicates the subsequent constructor entry. Remove it. (I'm not sure why this is being caught by the linter on my local machine but not in CI.) PR-URL: nodejs#41604 Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
danielleadams
added a commit
that referenced
this issue
Feb 28, 2022
The entry contains incorrect parameters and duplicates the subsequent constructor entry. Remove it. (I'm not sure why this is being caught by the linter on my local machine but not in CI.) PR-URL: #41604 Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
danielleadams
added a commit
that referenced
this issue
Mar 2, 2022
The entry contains incorrect parameters and duplicates the subsequent constructor entry. Remove it. (I'm not sure why this is being caught by the linter on my local machine but not in CI.) PR-URL: #41604 Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
danielleadams
added a commit
that referenced
this issue
Mar 3, 2022
The entry contains incorrect parameters and duplicates the subsequent constructor entry. Remove it. (I'm not sure why this is being caught by the linter on my local machine but not in CI.) PR-URL: #41604 Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
danielleadams
added a commit
that referenced
this issue
Mar 14, 2022
The entry contains incorrect parameters and duplicates the subsequent constructor entry. Remove it. (I'm not sure why this is being caught by the linter on my local machine but not in CI.) PR-URL: #41604 Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The entry contains incorrect parameters and duplicates the subsequent
constructor entry. Remove it.
(I'm not sure why this is being caught by the linter on my local machine
but not in CI.)