X Tutup
The Wayback Machine - https://web.archive.org/web/20220203014336/https://github.com/python/cpython/pull/26680
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-44389: Remove duplicate SSL_OP_NO_TLSv1_2 flag #26680

Merged
merged 1 commit into from Jun 12, 2021
Merged

bpo-44389: Remove duplicate SSL_OP_NO_TLSv1_2 flag #26680

merged 1 commit into from Jun 12, 2021

Conversation

@erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Jun 11, 2021 •
edited by bedevere-bot

https://bugs.python.org/issue44389
@erlend-aasland erlend-aasland requested a review from tiran Jun 11, 2021
nanjekyejoannah
nanjekyejoannah approved these changes Jun 12, 2021
View changes
Copy link
Contributor

@nanjekyejoannah nanjekyejoannah left a comment

Looks okay to me, @tiran can confirm on this.

@erlend-aasland
Copy link
Contributor Author

@erlend-aasland erlend-aasland commented Jun 12, 2021

Thanks for reviewing, @nanjekyejoannah! I figure this is just a copy-and-paste error.

nanjekyejoannah
nanjekyejoannah reviewed Jun 12, 2021
View changes
Copy link
Contributor

@nanjekyejoannah nanjekyejoannah left a comment

I agree, let me merge this. Christian can complain, if it was not meant to be.

@nanjekyejoannah nanjekyejoannah merged commit cb7230c into python:main Jun 12, 2021
13 checks passed
@erlend-aasland erlend-aasland deleted the remove-duplicate-ssl-flag branch Jun 12, 2021
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jun 13, 2021

Thanks @erlend-aasland for the PR, and @nanjekyejoannah for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

miss-islington added a commit to miss-islington/cpython that referenced this issue Jun 13, 2021
@erlend-aasland @miss-islington
bpo-44389: Remove duplicate SSL_OP_NO_TLSv1_2 flag (pythonGH-26680)
82a43de 
(cherry picked from commit cb7230c)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Jun 13, 2021

GH-26704 is a backport of this pull request to the 3.10 branch.

miss-islington added a commit that referenced this issue Jun 13, 2021
@erlend-aasland @miss-islington
bpo-44389: Remove duplicate SSL_OP_NO_TLSv1_2 flag (GH-26680)
f30f484 
(cherry picked from commit cb7230c)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
jdevries3133 added a commit to jdevries3133/cpython that referenced this issue Jun 19, 2021
@erlend-aasland @jdevries3133
bpo-44389: Remove duplicate SSL_OP_NO_TLSv1_2 flag (pythonGH-26680)
732ecab
@pablogsal pablogsal mentioned this pull request Jul 18, 2021
Closed
JuniorJPDJ added a commit to JuniorJPDJ/cpython that referenced this issue Aug 12, 2021
@erlend-aasland @JuniorJPDJ
bpo-44389: Remove duplicate SSL_OP_NO_TLSv1_2 flag (pythonGH-26680)
3338899
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nanjekyejoannah nanjekyejoannah

@tiran tiran

Assignees
No one assigned
Labels
CLA signed skip news
Projects
None yet
Milestone
No milestone
6 participants
@erlend-aasland @miss-islington @bedevere-bot @nanjekyejoannah @tiran @the-knights-who-say-ni
X Tutup