X Tutup
The Wayback Machine - https://web.archive.org/web/20221223070158/https://github.com/python/cpython/pull/30993
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-46565: del loop vars that are leaking into module namespaces #30993

Merged
merged 2 commits into from Feb 3, 2022
Merged

bpo-46565: del loop vars that are leaking into module namespaces #30993

merged 2 commits into from Feb 3, 2022

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Jan 28, 2022 •
edited by bedevere-bot

@sobolevn sobolevn requested a review from a team as a code owner Jan 28, 2022
merwok
merwok reviewed Jan 29, 2022
View changes
Lib/http/cookiejar.py Outdated Show resolved Hide resolved
merwok
merwok reviewed Jan 29, 2022
View changes
Lib/test/test_inspect.py
@@ -108,7 +108,7 @@ def istest(self, predicate, exp):
self.assertFalse(other(obj), 'not %s(%s)' % (other.__name__, exp))

def test__all__(self):
support.check__all__(self, inspect, not_exported=("k", "v", "mod_dict", "modulesbyfile"))
Copy link
Member

@merwok merwok Jan 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ha! this test should have caught the issue earlier 🙂

@sobolevn @merwok
Update Lib/http/cookiejar.py
cb5f9b8 
Co-authored-by: Éric <merwok@netwok.org>
serhiy-storchaka
serhiy-storchaka approved these changes Jan 29, 2022
View changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

LGTM.

@serhiy-storchaka serhiy-storchaka merged commit 0cbdd21 into python:main Feb 3, 2022
12 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Feb 3, 2022

Thanks @sobolevn for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington
Copy link
Contributor

miss-islington commented Feb 3, 2022

Thanks @sobolevn for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Feb 3, 2022

Sorry, @sobolevn and @serhiy-storchaka, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 0cbdd2131195b0d313762968f604e80a3e65ca9f 3.9

@miss-islington
Copy link
Contributor

miss-islington commented Feb 3, 2022

Sorry @sobolevn and @serhiy-storchaka, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 0cbdd2131195b0d313762968f604e80a3e65ca9f 3.10

@miss-islington
Copy link
Contributor

miss-islington commented Feb 3, 2022

Thanks @sobolevn for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Feb 3, 2022

Sorry, @sobolevn and @serhiy-storchaka, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 0cbdd2131195b0d313762968f604e80a3e65ca9f 3.10

@serhiy-storchaka serhiy-storchaka removed their assignment Apr 25, 2022
@sobolevn sobolevn mentioned this pull request Apr 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merwok merwok

@serhiy-storchaka serhiy-storchaka

@raghavthind2005 raghavthind2005

@python/email-team email-team

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@sobolevn @miss-islington @merwok @serhiy-storchaka @raghavthind2005 @the-knights-who-say-ni @bedevere-bot @AlexWaygood
X Tutup