bpo-45279: avoid redundant _commit_removals self._pending_removals guard#28546
Closed
graingert wants to merge 2 commits intopython:mainfrom
Closed
bpo-45279: avoid redundant _commit_removals self._pending_removals guard#28546graingert wants to merge 2 commits intopython:mainfrom
graingert wants to merge 2 commits intopython:mainfrom
Conversation
Contributor
|
I believe, the check exists for the sake of performance: condition check is much faster than function call in Python. |
|
This PR is stale because it has been open for 30 days with no activity. |
Member
|
@graingert what do you think? I'd be inclined to close this as the change may hurt performance and there's little clear benefit, so we should default to keeping things as they are. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue45279
_commit_removalsalready checks if pending_removals is empty viapop()cpython/Lib/_weakrefset.py
Lines 53 to 61 in 3f8b23f