stream: iterator helpers synchronous errors #41652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested: |
benjamingr
reviewed
Jan 22, 2022
benjamingr
approved these changes
Jan 22, 2022
Thanks, this looks good to me, it makes sense to also fix this for filter as well :)
benjamingr
reviewed
Jan 22, 2022
ronag
approved these changes
Jan 23, 2022
iMoses
force-pushed
the
iterator-helpers-sync-validation
branch
3 times, most recently
from
f90e4d9
to
8bdf558
Compare
|
Let's get CI to pass and then land this :) |
Commit Queue failed- Loading data for nodejs/node/pull/41652 ✔ Done loading data for nodejs/node/pull/41652 ----------------------------------- PR info ------------------------------------ Title stream: iterator helpers synchronous errors (#41652) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch iMoses:iterator-helpers-sync-validation -> nodejs:master Labels stream, needs-ci Commits 1 - stream: iterator helpers synchronous errors Committers 1 - iMoses PR-URL: https://github.com/nodejs/node/pull/41652 Fixes: https://github.com/nodejs/node/issues/41648 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Matteo Collina Reviewed-By: Robert Nagy ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/41652 Fixes: https://github.com/nodejs/node/issues/41648 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Matteo Collina Reviewed-By: Robert Nagy -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - stream: iterator helpers synchronous errors ℹ This PR was created on Sat, 22 Jan 2022 20:36:23 GMT ✔ Approvals: 3 ✔ - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/41652#pullrequestreview-860239785 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/41652#pullrequestreview-860241270 ✔ - Robert Nagy (@ronag) (TSC): https://github.com/nodejs/node/pull/41652#pullrequestreview-860290302 ✖ GitHub CI is still running ℹ Last Full PR CI on 2022-01-25T09:58:30Z: https://ci.nodejs.org/job/node-test-pull-request/42132/ - Querying data for job/node-test-pull-request/42132/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1744970014 |
Commit Queue failed- Loading data for nodejs/node/pull/41652 ✔ Done loading data for nodejs/node/pull/41652 ----------------------------------- PR info ------------------------------------ Title stream: iterator helpers synchronous errors (#41652) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch iMoses:iterator-helpers-sync-validation -> nodejs:master Labels stream, needs-ci Commits 1 - stream: iterator helpers synchronous errors Committers 1 - iMoses PR-URL: https://github.com/nodejs/node/pull/41652 Fixes: https://github.com/nodejs/node/issues/41648 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Matteo Collina Reviewed-By: Robert Nagy ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/41652 Fixes: https://github.com/nodejs/node/issues/41648 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Matteo Collina Reviewed-By: Robert Nagy -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - stream: iterator helpers synchronous errors ℹ This PR was created on Sat, 22 Jan 2022 20:36:23 GMT ✔ Approvals: 3 ✔ - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/41652#pullrequestreview-860239785 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/41652#pullrequestreview-860241270 ✔ - Robert Nagy (@ronag) (TSC): https://github.com/nodejs/node/pull/41652#pullrequestreview-860290302 ✖ Last GitHub CI failed ℹ Last Full PR CI on 2022-01-25T14:23:50Z: https://ci.nodejs.org/job/node-test-pull-request/42140/ - Querying data for job/node-test-pull-request/42140/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1745928514 |
30 tasks
is no longer a generator function, instead it returns a called generator so that validation can be synchronous and not wait for the first iteration Fixes: nodejs#41648
iMoses
force-pushed
the
iterator-helpers-sync-validation
branch
from
1947faf
to
3fe2810
Compare
benjamingr
approved these changes
Jan 27, 2022
|
Landed in 5d9caa1 |
|
Congrats on your first contribution and patience @iMoses - let's talk about the next one :)? |
22 tasks
22 tasks
25 tasks
28 tasks
Linkgoron
added a commit
to Linkgoron/node
that referenced
this issue
Jan 31, 2022
is no longer a generator function, instead it returns a called generator so that validation can be synchronous and not wait for the first iteration Fixes: nodejs#41648 PR-URL: nodejs#41652 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com>
31 tasks
ruyadorno
added a commit
that referenced
this issue
Feb 8, 2022
is no longer a generator function, instead it returns a called generator so that validation can be synchronous and not wait for the first iteration Fixes: #41648 PR-URL: #41652 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
streams/operators/mapis no longer a generator function,instead it returns a called generator so that validation can be
synchronous and not wait for the first iteration
Fixes: #41648