X Tutup
The Wayback Machine - https://web.archive.org/web/20250605090502/https://github.com/nodejs/node/issues/41717
Skip to content

[URL] Split forbidden host/domain code points, and add all C0 controls and add U+007F to the latter #41717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
karwa opened this issue Jan 27, 2022 · 1 comment · Fixed by #43190
Closed

[URL] Split forbidden host/domain code points, and add all C0 controls and add U+007F to the latter #41717

karwa opened this issue Jan 27, 2022 · 1 comment · Fixed by #43190
Labels
whatwg-url Issues and PRs related to the WHATWG URL implementation.

Comments

@karwa
Copy link

karwa commented Jan 27, 2022 •
edited
Loading

Version

N/A

Platform

N/A

Subsystem

URL

What steps will reproduce the bug?

No response

How often does it reproduce? Is there a required condition?

No response

What is the expected behavior?

Spec update: Domains may not contain C0 controls or U+007F DELETE. Opaque hostnames remain unchanged.

See: whatwg/url#685

What do you see instead?

N/A

Additional information

Sorry if this is not the right way to submit this issue. It was either this (bug) or a feature request. And it didn't seem like a feature request.
@karwa karwa mentioned this issue Jan 27, 2022
Merged
3 tasks
@targos targos added the whatwg-url Issues and PRs related to the WHATWG URL implementation. label Jan 27, 2022
@benjamingr
Copy link
Member

@nodejs/url note this landed so to align with the spec it should probably be fixed in Node

@F3n67u F3n67u mentioned this issue May 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
whatwg-url Issues and PRs related to the WHATWG URL implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test, url: update WHATWG URL parser to align with latest spec F3n67u/node
3 participants
@benjamingr @targos @karwa
X Tutup