X Tutup
The Wayback Machine - https://web.archive.org/web/20211218174051/https://github.com/microsoft/TypeScript/pull/46985
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin chalk to ^4.1 #46985

Merged
merged 2 commits into from Dec 2, 2021
Merged

Pin chalk to ^4.1 #46985

merged 2 commits into from Dec 2, 2021

Conversation

@rbuckton
Copy link
Member

@rbuckton rbuckton commented Dec 1, 2021

This limits the version of chalk we use to ^4.1.2 since chalk@5 is now ESM only.

@jakebailey
Copy link
Member

@jakebailey jakebailey commented Dec 1, 2021

The PR is so huge I think because the lock was generated with npm7+; I think the old lock was npm 6 (so lock version 1); maybe redo this with npm 6 to prevent churn?

@rbuckton
Copy link
Member Author

@rbuckton rbuckton commented Dec 1, 2021

Regenerated the lock file using npm@6

@MartinJohns
Copy link
Contributor

@MartinJohns MartinJohns commented Dec 1, 2021

Related: #46931

Might want to revert those changes when you're pinning chalk anyway.

@jakebailey
Copy link
Member

@jakebailey jakebailey commented Dec 1, 2021

Hm, perhaps we could change the offending build script (or, it was missed). Not sure where the user test PR thingy lives.

@jakebailey
Copy link
Member

@jakebailey jakebailey commented Dec 1, 2021

(Pinning back and removing the odd import is good too.)

@rbuckton
Copy link
Member Author

@rbuckton rbuckton commented Dec 2, 2021

I pinged @orta on that PR, but I'll mention him here too. Do we want to depend on import() for chalk or just pin it to ^4.2.1?

@orta
Copy link
Member

@orta orta commented Dec 2, 2021

Pinning to 4.2 is fine IMO 👍🏻 - both solve the underlaying issue.

Makes sense that this would break on older nodes which don't support node's import infra. If this is forcing an update to the build infra then we can ship it independently later once that's sorted.

@rbuckton
Copy link
Member Author

@rbuckton rbuckton commented Dec 2, 2021

I've reverted the changes in #46931 as well.

orta
orta approved these changes Dec 2, 2021
@rbuckton rbuckton merged commit c792a66 into main Dec 2, 2021
11 checks passed
@rbuckton rbuckton deleted the pinChalk branch Dec 2, 2021
@andrewbranch
Copy link
Member

@andrewbranch andrewbranch commented Dec 3, 2021

@typescript-bot cherry-pick this to release-4.5

@typescript-bot
Copy link
Collaborator

@typescript-bot typescript-bot commented Dec 3, 2021

Heya @andrewbranch, I've started to run the task to cherry-pick this into release-4.5 on this PR at e1b49bb. You can monitor the build here.

@andrewbranch
Copy link
Member

@andrewbranch andrewbranch commented Dec 3, 2021

I think this doesn't work after the branch has been deleted but we'll see

@typescript-bot
Copy link
Collaborator

@typescript-bot typescript-bot commented Dec 3, 2021

Hey @andrewbranch, I couldn't open a PR with the cherry-pick. (You can check the log here). You may need to squash and pick this PR into release-4.5 manually.

andrewbranch added a commit to andrewbranch/TypeScript that referenced this issue Dec 3, 2021
andrewbranch added a commit that referenced this issue Dec 3, 2021
* Pin chalk to ^4.1

* Revert #46931

Co-authored-by: Ron Buckton <ron.buckton@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
X Tutup